Skip to content

JRuby integration improvements. #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

JRuby integration improvements. #528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5f5498
Remove support for Ruby 3.1
faisal Mar 28, 2025
0ae40fc
add platform value to the gemspec, and require jar-dependencies version
etagwerker Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,16 @@ jobs:
fail-fast: false
matrix:
ruby-version:
- '3.1'
- '3.2'
- '3.3'
- '3.4'
experimental: [false]
include:
- ruby-version: 'ruby-head'
experimental: true
- ruby-version: 'jruby-9.4'
- ruby-version: 'jruby-10'
experimental: true
continue-on-error: true
steps:
- uses: actions/checkout@v4
- name: Set up Ruby ${{ matrix.ruby-version }}
Expand All @@ -59,16 +59,16 @@ jobs:
fail-fast: false
matrix:
ruby-version:
- '3.1'
- '3.2'
- '3.3'
- '3.4'
experimental: [false]
include:
- ruby-version: 'ruby-head'
experimental: true
- ruby-version: 'jruby-9.4'
- ruby-version: 'jruby-10'
experimental: true
continue-on-error: true
steps:
- uses: actions/checkout@v4
- name: Set up Ruby ${{ matrix.ruby-version }}
Expand All @@ -89,16 +89,16 @@ jobs:
fail-fast: false
matrix:
ruby-version:
- '3.1'
- '3.2'
- '3.3'
- '3.4'
experimental: [false]
include:
- ruby-version: 'ruby-head'
experimental: true
- ruby-version: 'jruby-9.4'
- ruby-version: 'jruby-10'
experimental: true
continue-on-error: true
steps:
- uses: actions/checkout@v4
- name: Set up Ruby ${{ matrix.ruby-version }}
Expand All @@ -119,16 +119,16 @@ jobs:
fail-fast: false
matrix:
ruby-version:
- '3.1'
- '3.2'
- '3.3'
- '3.4'
experimental: [false]
include:
- ruby-version: 'ruby-head'
experimental: true
- ruby-version: 'jruby-9.4'
- ruby-version: 'jruby-10'
experimental: true
continue-on-error: true

steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ AllCops:
- 'tmp/**/*'
- 'vendor/**/*'
- 'gemfiles/*'
TargetRubyVersion: 3.1
TargetRubyVersion: 3.2

Metrics/BlockLength:
Enabled: false
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# main [(unreleased)](https://github.com/whitesmith/rubycritic/compare/v4.9.2...main)

* [CHANGE] Drop support for Ruby 3.1.x, including moving CI from JRuby 9.4 to JRuby 10 (by [@faisal][])
* [CHANGE] Bump aruba, byebug, cucumber, fakefs, rake, reek dependencies (by [@faisal][])
* [BUGFIX] Work around issue preventing feature execution on Ruby 3.5.0dev (by [@faisal][])
* [CHANGE] Add changes or suppress warnings for issues found by newer rubocop (by [@faisal][])
Expand Down
4 changes: 3 additions & 1 deletion rubycritic.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,15 @@ require 'rubycritic/version'
Gem::Specification.new do |spec|
spec.name = 'rubycritic'
spec.version = RubyCritic::VERSION
spec.platform = RUBY_PLATFORM == 'java' ? Gem::Platform::JAVA : Gem::Platform::RUBY
spec.authors = ['Guilherme Simoes']
spec.email = ['[email protected]']
spec.description = 'RubyCritic is a tool that wraps around various static analysis gems ' \
'to provide a quality report of your Ruby code.'
spec.summary = 'RubyCritic is a Ruby code quality reporter'
spec.homepage = 'https://github.com/whitesmith/rubycritic'
spec.license = 'MIT'
spec.required_ruby_version = '>= 3.1.0'
spec.required_ruby_version = '>= 3.2.0'

spec.files = [
'CHANGELOG.md',
Expand Down Expand Up @@ -45,6 +46,7 @@ Gem::Specification.new do |spec|
spec.add_development_dependency 'aruba', '~> 2.3.1', '>= 2.3.1'
spec.add_development_dependency 'bundler', '>= 2.0.0'
if RUBY_PLATFORM == 'java'
spec.add_development_dependency 'jar-dependencies', '~> 0.5.4'
spec.add_development_dependency 'pry-debugger-jruby'
else
spec.add_development_dependency 'byebug', '~> 12.0', '>= 10.0'
Expand Down