-
Notifications
You must be signed in to change notification settings - Fork 71
Feat: add prometheus observability #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Further research showed we can just have callback hooks for the metrics but for for some wierd reason prometheus exposes api as float even though it uses uint64 internally. Also although I disabled the default metrics there are some useful info Do we want that too @wind-c ? Or does it feel like too much noise? |
|
You have added quite a lot of code. I will need some time to review it! Thank you very much for your exploration. Let's work together! |
Exploring some more examples I saw callbacks is also an option. Wierd thing is they use float for API access even though internally it stores as atomic uint64.
Fixes: #136