feat: add retry logic to get_step_of_flow_status using backon #6411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=80&v=4){kind=small}
- Added backon retry with constant backoff (500ms delay, max 3 retries) - Added warning logs for retry attempts to aid debugging - Follows existing codebase patterns for retry resilience - Improves reliability when fetching flow status information Co-authored-by: windmill-internal-app[bot] <windmill-internal-app[bot]@users.noreply.github.com>
Open
Deploying windmill with
|
| Latest commit: |
7a82904
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://33be8f07.windmill.pages.dev |
| Branch Preview URL: | https://claude-issue-6410-20250819-0.windmill.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implemented retry logic in the
get_step_of_flow_statusfunction using the backon library for additional resilience as requested in issue #6410.Changes
windmill-queue/src/flow_status.rsImplementation Details
The retry logic specifically addresses potential failures in:
The implementation uses:
Testing
The changes follow the established patterns used elsewhere in the windmill codebase for retry logic. The SQLx query structure remains unchanged, only wrapped with retry functionality.
Resolves #6410
Generated with Claude Code