fix: reset button for preprocessor scripts now uses preprocessor signature #6595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=80&v=4){kind=small}
…ature - Added selectedTab prop to EditorBar component to track active tab - Modified clearContent function to use preprocessor signature when on preprocessor tab - Added getPreprocessorCode helper function to return appropriate preprocessor template - Updated ScriptEditor to pass selectedTab to EditorBar - Updated WorkspaceScriptPicker and PickHubScript type definitions to support preprocessor kind Fixes #6594 Co-authored-by: windmill-internal-app[bot] <windmill-internal-app[bot]@users.noreply.github.com>
Deploying windmill with
|
| Latest commit: |
e60ffcb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b5641471.windmill.pages.dev |
| Branch Preview URL: | https://claude-issue-6594-20250911-2.windmill.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the reset button behavior for preprocessor scripts in the Monaco editor. Previously, when clicking the reset button while on the preprocessor tab, it would reset to the main function signature instead of the appropriate preprocessor function signature.
Changes
selectedTabprop to EditorBar component to track whether main or preprocessor tab is activeclearContentfunction to check if we're on the preprocessor tab and use the correct signaturegetPreprocessorCodehelper function that returns the appropriate preprocessor template for TypeScript/Deno/Bun and PythonselectedTabprop to EditorBarTest Plan
Fixes #6594
🤖 Generated with Claude Code