feat: optimized IO file logger #4078

MohamadJaara · 2025-06-23T16:04:34Z

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

the current LogFileWriter have some short comming

it start a new new file writer for each line
it flushes each log line directly into storage creating

Solutions

create a new async logger
buffer log lines and flushes with a set interval
since the logger is now async add a crash handler to make sure crashes are logged
also when the app start check if there are any oom or ANRs from the previous app start
have a dedicated process that listens to logcat
keep the old logger as it is and enable the new one only in internal builds

Needs releases with:

GitHub link to other pull request

Testing

Test Coverage (Optional)

I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…mplementations

codecov · 2025-06-23T16:17:27Z

Codecov Report

❌ Patch coverage is 0% with 227 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.15%. Comparing base (ec84f31) to head (83c91d4).

Files with missing lines	Patch %	Lines
...m/wire/android/util/logging/LogFileWriterV2Impl.kt	0.00%	179 Missing ⚠️
...rc/main/kotlin/com/wire/android/WireApplication.kt	0.00%	35 Missing ⚠️
...wire/android/util/logging/LogFileWriterV2Config.kt	0.00%	7 Missing ⚠️
...m/wire/android/util/logging/LogFileWriterV1Impl.kt	0.00%	3 Missing ⚠️
...in/com/wire/android/ui/debug/UserDebugViewModel.kt	0.00%	2 Missing ⚠️
...lin/com/wire/android/util/logging/LogFileWriter.kt	0.00%	1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4078      +/-   ##
===========================================
- Coverage    47.74%   47.15%   -0.59%     
===========================================
  Files          525      528       +3     
  Lines        17918    18142     +224     
  Branches      2950     2979      +29     
===========================================
  Hits          8555     8555              
- Misses        8481     8705     +224     
  Partials       882      882

Files with missing lines	Coverage Δ
...re/android/notification/WireNotificationManager.kt	`80.26% <ø> (ø)`
...in/com/wire/android/services/CallServiceManager.kt	`93.44% <ø> (ø)`
...in/kotlin/com/wire/android/util/logging/LogUtil.kt	`0.00% <ø> (ø)`
...lin/com/wire/android/util/logging/LogFileWriter.kt	`0.00% <0.00%> (ø)`
...in/com/wire/android/ui/debug/UserDebugViewModel.kt	`0.00% <0.00%> (ø)`
...m/wire/android/util/logging/LogFileWriterV1Impl.kt	`0.00% <0.00%> (ø)`
...wire/android/util/logging/LogFileWriterV2Config.kt	`0.00% <0.00%> (ø)`
...rc/main/kotlin/com/wire/android/WireApplication.kt	`0.00% <0.00%> (ø)`
...m/wire/android/util/logging/LogFileWriterV2Impl.kt	`0.00% <0.00%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec84f31...83c91d4. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…-logging

github-actions · 2025-06-25T09:13:59Z

Built wire-android-staging-compat-pr-4078.apk is available for download

github-actions · 2025-06-25T09:14:20Z

Built wire-android-dev-debug-pr-4078.apk is available for download

# Conflicts: # default.json

sonarqubecloud · 2025-07-18T09:09:04Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
8.4% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-07-18T09:46:58Z

Built wire-android-staging-compat-pr-4078.apk is available for download

github-actions · 2025-07-18T09:47:12Z

Built wire-android-dev-debug-pr-4078.apk is available for download

github-actions · 2025-08-18T00:41:09Z

This PR is stale because it has been open 30 days with no activity. Please update it or close it in case is not relevant anymore.

# Conflicts: # app/src/androidTest/kotlin/com/wire/android/ui/debug/DebugScreenComposeTest.kt # app/src/main/kotlin/com/wire/android/services/CallService.kt

# Conflicts: # app/src/main/kotlin/com/wire/android/ui/debug/DebugScreen.kt # buildSrc/src/main/kotlin/customization/FeatureConfigs.kt # default.json

# Conflicts: # buildSrc/src/main/kotlin/customization/FeatureConfigs.kt # default.json

…-logging # Conflicts: # buildSrc/src/main/kotlin/customization/FeatureConfigs.kt # default.json

yamilmedina

Looking good, gave a few suggestions about resource closure and a couple of questions.

app/src/main/kotlin/com/wire/android/util/logging/LogFileWriterV2Impl.kt

…-logging # Conflicts: # default.json

…rV2Impl.kt Co-authored-by: Yamil Medina <[email protected]>

sonarqubecloud · 2025-10-08T10:17:22Z

Quality Gate failed

Failed conditions
8.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

yamilmedina

🚀

MohamadJaara added 3 commits June 23, 2025 10:13

feat(logging): introduce thread-safe logging with new LogFileWriter i…

ba6db78

…mplementations

quick change

6132313

refactor(logging): remove unused MEMORY_PRESSURE_MULTIPLIER constant

ac80293

pull-request-size bot added the size/L label Jun 23, 2025

github-actions bot assigned MohamadJaara Jun 23, 2025

remove not used value

948574f

MohamadJaara changed the title ~~Mo/feat/thred safe logging~~ feat: reduced IO logger Jun 23, 2025

Merge branch 'develop' into mo/feat/thred-safe-logging

af9c37f

MohamadJaara added 4 commits June 25, 2025 09:34

Merge remote-tracking branch 'origin/develop' into mo/feat/thred-safe…

bad4ee3

…-logging

detekt

a63eaf0

Merge branch 'develop' into mo/feat/thred-safe-logging

b4be3ee

detekt

0c1cc7d

MohamadJaara requested review from yamilmedina and vitorhugods July 1, 2025 13:26

MohamadJaara changed the title ~~feat: reduced IO logger~~ feat: optimized IO file logger Jul 7, 2025

MohamadJaara added 2 commits July 18, 2025 11:05

Merge branch 'develop' into mo/feat/thred-safe-logging

816b392

# Conflicts: # default.json

Merge branch 'develop' into mo/feat/thred-safe-logging

266003d

github-actions bot added the stale Inactivity alert label Aug 18, 2025

Merge branch 'develop' into mo/feat/thred-safe-logging

d4068f8

# Conflicts: # app/src/androidTest/kotlin/com/wire/android/ui/debug/DebugScreenComposeTest.kt # app/src/main/kotlin/com/wire/android/services/CallService.kt

stale bot removed the stale Inactivity alert label Aug 20, 2025

MohamadJaara added 3 commits August 20, 2025 13:24

detekt

8268a73

Merge branch 'develop' into mo/feat/thred-safe-logging

f1dfbae

# Conflicts: # app/src/main/kotlin/com/wire/android/ui/debug/DebugScreen.kt # buildSrc/src/main/kotlin/customization/FeatureConfigs.kt # default.json

fix merge conflicts

abf7c44

MohamadJaara added 6 commits September 15, 2025 17:37

Merge branch 'develop' into mo/feat/thred-safe-logging

3849cbb

# Conflicts: # buildSrc/src/main/kotlin/customization/FeatureConfigs.kt # default.json

Merge branch 'develop' into mo/feat/thred-safe-logging

106e806

Merge branch 'develop' into mo/feat/thred-safe-logging

28844fc

Merge remote-tracking branch 'origin/develop' into mo/feat/thred-safe…

55b15c5

…-logging # Conflicts: # buildSrc/src/main/kotlin/customization/FeatureConfigs.kt # default.json

Merge branch 'develop' into mo/feat/thred-safe-logging

1e2c629

Merge branch 'develop' into mo/feat/thred-safe-logging

106a7d1

yamilmedina reviewed Oct 7, 2025

View reviewed changes

MohamadJaara and others added 4 commits October 8, 2025 10:43

Merge remote-tracking branch 'origin/develop' into mo/feat/thred-safe…

281988f

…-logging # Conflicts: # default.json

Update app/src/main/kotlin/com/wire/android/util/logging/LogFileWrite…

12b0720

…rV2Impl.kt Co-authored-by: Yamil Medina <[email protected]>

Update app/src/main/kotlin/com/wire/android/util/logging/LogFileWrite…

745718f

…rV2Impl.kt Co-authored-by: Yamil Medina <[email protected]>

pr comments

e6cc9de

MohamadJaara force-pushed the mo/feat/thred-safe-logging branch from afc0c1a to e6cc9de Compare October 8, 2025 09:34

MohamadJaara requested a review from yamilmedina October 8, 2025 10:06

enable the async logger for for beta

83c91d4

yamilmedina approved these changes Oct 8, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: optimized IO file logger #4078

feat: optimized IO file logger #4078

MohamadJaara commented Jun 23, 2025

Uh oh!

codecov bot commented Jun 23, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 25, 2025

Uh oh!

github-actions bot commented Jun 25, 2025

Uh oh!

sonarqubecloud bot commented Jul 18, 2025

Uh oh!

github-actions bot commented Jul 18, 2025

Uh oh!

github-actions bot commented Jul 18, 2025

Uh oh!

github-actions bot commented Aug 18, 2025

Uh oh!

yamilmedina left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Oct 8, 2025

Uh oh!

yamilmedina left a comment

Uh oh!

Uh oh!

feat: optimized IO file logger #4078

Are you sure you want to change the base?

feat: optimized IO file logger #4078

Conversation

MohamadJaara commented Jun 23, 2025

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Solutions

Testing

Test Coverage (Optional)

How to Test

Notes (Optional)

Attachments (Optional)

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

Uh oh!

codecov bot commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jun 25, 2025

Uh oh!

github-actions bot commented Jun 25, 2025

Uh oh!

sonarqubecloud bot commented Jul 18, 2025

Quality Gate passed

Uh oh!

github-actions bot commented Jul 18, 2025

Uh oh!

github-actions bot commented Jul 18, 2025

Uh oh!

github-actions bot commented Aug 18, 2025

Uh oh!

yamilmedina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Oct 8, 2025

Quality Gate failed

Uh oh!

yamilmedina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Jun 23, 2025 •

edited

Loading