Skip to content

Conversation

sbakhtiarov
Copy link
Contributor

@sbakhtiarov sbakhtiarov commented Sep 19, 2025

TaskWPB-20230 [Android] Respond to QR code backend feature flag and turn QR code feature on / off according to flag setting

https://wearezeta.atlassian.net/browse/WPB-20230

What's new in this PR?

New feature flag to hide QR code on user profile page.

  • Hide QR code on profile page
  • Disable opening profile page from deep link

@sbakhtiarov sbakhtiarov force-pushed the feat/simplified-connection-request branch 2 times, most recently from 81e83c4 to e31ea39 Compare September 19, 2025 15:39
@sbakhtiarov sbakhtiarov changed the title feat: simplified user connection request (WPB-20230) feat: disable profile QR code feature flag (WPB-20230) Sep 19, 2025
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.76%. Comparing base (ec84f31) to head (63b86fd).

Files with missing lines Patch % Lines
...otlin/com/wire/android/ui/WireActivityViewModel.kt 71.42% 1 Missing and 1 partial ⚠️
...i/debug/featureflags/DebugFeatureFlagsViewModel.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4285      +/-   ##
===========================================
+ Coverage    47.74%   47.76%   +0.01%     
===========================================
  Files          525      525              
  Lines        17918    17930      +12     
  Branches      2950     2952       +2     
===========================================
+ Hits          8555     8564       +9     
- Misses        8481     8483       +2     
- Partials       882      883       +1     
Files with missing lines Coverage Δ
...ndroid/ui/userprofile/self/SelfUserProfileState.kt 100.00% <100.00%> (ø)
...id/ui/userprofile/self/SelfUserProfileViewModel.kt 56.25% <100.00%> (+1.57%) ⬆️
.../wire/android/util/debug/FeatureVisibilityFlags.kt 0.00% <ø> (ø)
...i/debug/featureflags/DebugFeatureFlagsViewModel.kt 0.00% <0.00%> (ø)
...otlin/com/wire/android/ui/WireActivityViewModel.kt 74.06% <71.42%> (-0.25%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec84f31...63b86fd. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbakhtiarov sbakhtiarov force-pushed the feat/simplified-connection-request branch from e31ea39 to 73b2bf8 Compare September 22, 2025 11:28
@sbakhtiarov sbakhtiarov marked this pull request as ready for review September 22, 2025 11:39
@MohamadJaara
Copy link
Member

this is only to show the QR code, i would assume the app should not react to the deeplink in this case, otherwise if the QR is obtained another way, the app will still react to it

@sbakhtiarov
Copy link
Contributor Author

this is only to show the QR code, i would assume the app should not react to the deeplink in this case, otherwise if the QR is obtained another way, the app will still react to it

I will check it

@sbakhtiarov sbakhtiarov requested review from MohamadJaara and yamilmedina and removed request for vitorhugods and yamilmedina September 23, 2025 08:02
Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! 🚀
I think we can remove a leftover feature flag used while developing 1 year ago, since this is now controlled by BE :D

@sbakhtiarov sbakhtiarov force-pushed the feat/simplified-connection-request branch from 60397c3 to d90c22f Compare September 25, 2025 14:03
@sbakhtiarov sbakhtiarov force-pushed the feat/simplified-connection-request branch 2 times, most recently from 8a1a4b5 to 0ad8ff7 Compare October 7, 2025 15:08
@sbakhtiarov sbakhtiarov force-pushed the feat/simplified-connection-request branch from 0ad8ff7 to 63b86fd Compare October 8, 2025 11:32
Copy link

sonarqubecloud bot commented Oct 8, 2025

@sbakhtiarov sbakhtiarov added this pull request to the merge queue Oct 8, 2025
Merged via the queue into develop with commit 2c7210d Oct 8, 2025
15 of 16 checks passed
@sbakhtiarov sbakhtiarov deleted the feat/simplified-connection-request branch October 8, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants