Skip to content

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Oct 7, 2025

EpicWPB-19646 Android Device Management


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Collections of epics, for EMM support.

Solutions

Implemented in each approved PR listed here:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Install Test DCP to emulate managed configs.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Oct 7, 2025
Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 69.58333% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.74%. Comparing base (2b8d99f) to head (7ef6dcd).

Files with missing lines Patch % Lines
.../wire/android/emm/ManagedConfigurationsReporter.kt 5.00% 19 Missing ⚠️
.../wire/android/emm/ManagedConfigurationsReceiver.kt 69.23% 8 Missing and 4 partials ⚠️
...tion/broadcastreceivers/DynamicReceiversManager.kt 0.00% 10 Missing ⚠️
...m/wire/android/emm/ManagedConfigurationsManager.kt 88.31% 3 Missing and 6 partials ⚠️
...kotlin/com/wire/android/emm/ManagedServerConfig.kt 68.42% 0 Missing and 6 partials ⚠️
...id/ui/newauthentication/login/NewLoginViewModel.kt 72.72% 2 Missing and 1 partial ⚠️
...d/ui/authentication/login/sso/LoginSSOViewModel.kt 60.00% 2 Missing ⚠️
.../com/wire/android/emm/ManagedConfigurationsKeys.kt 75.00% 1 Missing ⚠️
...otlin/com/wire/android/emm/ManagedSSOCodeConfig.kt 88.88% 0 Missing and 1 partial ⚠️
...tication/create/code/CreateAccountCodeViewModel.kt 0.00% 1 Missing ⚠️
... and 9 more

❌ Your patch check has failed because the patch coverage (69.58%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4327      +/-   ##
===========================================
+ Coverage    47.51%   47.74%   +0.23%     
===========================================
  Files          518      525       +7     
  Lines        17710    17917     +207     
  Branches      2909     2949      +40     
===========================================
+ Hits          8415     8555     +140     
- Misses        8436     8480      +44     
- Partials       859      882      +23     
Files with missing lines Coverage Δ
...in/com/wire/android/config/ServerConfigProvider.kt 100.00% <100.00%> (ø)
...rc/main/kotlin/com/wire/android/ui/WireActivity.kt 0.00% <ø> (ø)
.../authentication/login/email/LoginEmailViewModel.kt 78.94% <100.00%> (+0.11%) ⬆️
.../com/wire/android/emm/ManagedConfigurationsKeys.kt 75.00% <75.00%> (ø)
...otlin/com/wire/android/emm/ManagedSSOCodeConfig.kt 88.88% <88.88%> (ø)
...tication/create/code/CreateAccountCodeViewModel.kt 0.00% <0.00%> (ø)
...on/create/details/CreateAccountDetailsViewModel.kt 87.17% <0.00%> (-2.57%) ⬇️
...cation/create/email/CreateAccountEmailViewModel.kt 47.05% <0.00%> (-1.97%) ⬇️
.../create/overview/CreateAccountOverviewViewModel.kt 0.00% <0.00%> (ø)
.../android/ui/authentication/login/LoginViewModel.kt 69.44% <75.00%> (+0.87%) ⬆️
... and 12 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b8d99f...7ef6dcd. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

sonarqubecloud bot commented Oct 7, 2025

@MohamadJaara MohamadJaara merged commit 2248ba6 into develop Oct 8, 2025
17 of 18 checks passed
@MohamadJaara MohamadJaara deleted the epic/emm/managed-configurations branch October 8, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants