Skip to content

Conversation

sbakhtiarov
Copy link
Contributor

@sbakhtiarov sbakhtiarov commented Oct 9, 2025

TaskWPB-20230 [Android] Respond to QR code backend feature flag and turn QR code feature on / off according to flag setting

https://wearezeta.atlassian.net/browse/WPB-20230

What's new in this PR?

Issues

App crash when user is not logged in.

Causes (Optional)

Injecting IsProfileQRCodeEnabledUseCase requires logged in user.

Solutions

Use Provider \ Factory pattern to handle users switch and handle no user case.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2025

@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.77%. Comparing base (e3a341e) to head (f1f6c03).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...otlin/com/wire/android/ui/WireActivityViewModel.kt 40.00% 1 Missing and 2 partials ⚠️

❌ Your patch check has failed because the patch coverage (40.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4333      +/-   ##
===========================================
+ Coverage    47.76%   47.77%   +0.01%     
===========================================
  Files          525      525              
  Lines        17930    17940      +10     
  Branches      2952     2953       +1     
===========================================
+ Hits          8564     8571       +7     
- Misses        8483     8485       +2     
- Partials       883      884       +1     
Files with missing lines Coverage Δ
...otlin/com/wire/android/ui/WireActivityViewModel.kt 73.89% <40.00%> (-0.17%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3a341e...f1f6c03. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yamilmedina yamilmedina added this pull request to the merge queue Oct 10, 2025
Merged via the queue into develop with commit 474f808 Oct 10, 2025
16 of 17 checks passed
@yamilmedina yamilmedina deleted the fix/profile-qr-inject-crash branch October 10, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants