Skip to content

Conversation

KaterinaWire
Copy link
Contributor

@KaterinaWire KaterinaWire commented Sep 25, 2025

TaskWPB-20271 [iOS] Main navigation item including a displayable CTA

Issue

Add Meetings tab bar item and hide it behind the developer flag:

Screenshot 2025-09-25 at 13 31 40

Design iPhone
Design iPad

Testing

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@KaterinaWire KaterinaWire marked this pull request as ready for review September 26, 2025 15:42
Copy link
Contributor

github-actions bot commented Sep 26, 2025

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit c93292f.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one comment before approving, also looking at the ticket do we need to remove the archive conversation tab and move it to conversation filter?

case .settings:
await mainCoordinator.showSettings()
case .meetings:
await mainCoordinator.showSettings()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: didn't you mean ?

Suggested change
await mainCoordinator.showSettings()
await mainCoordinator.showMeetings()

Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll hold off approving until @netbes comment is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants