-
Notifications
You must be signed in to change notification settings - Fork 24
feat: add meetings tab and developer flag - WPB-20271 #3640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit c93292f. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left one comment before approving, also looking at the ticket do we need to remove the archive conversation tab and move it to conversation filter?
case .settings: | ||
await mainCoordinator.showSettings() | ||
case .meetings: | ||
await mainCoordinator.showSettings() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: didn't you mean ?
await mainCoordinator.showSettings() | |
await mainCoordinator.showMeetings() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'll hold off approving until @netbes comment is resolved
Issue
Add Meetings tab bar item and hide it behind the developer flag:
Design iPhone
Design iPad
Testing
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: