Support casting of datetime with timezone information #1144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah well, supporting all platforms will not be that easy... I'll move this to a draft |
Before these changes, nanobind would silently accept datetime objects with timezone information and treat them as local time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before these changes, nanobind would silently accept datetime objects with timezone information and treat them as local time.
In the default case (tzinfo=None), the cost should be small.
However, reading the previous PR discussions, I realize that the maintenance of these chrono bindings is not a core goal of nanobind. So I'll leave it up to you if you think it is worth making these conversions a bit more robust.
cc @oremanj who contributed the initial version