Fix invalid output of DiscretePDF::sampleReuse due to precision
#32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some precision issue (the division operation not being very stable numerically if$\sqrt{1 - X}$ ). This simple fix prevent that from happenning (even if it screwed the distribution a little bit). This however should not be a problem as this issue is only an edge-case.
cdf[x+1] - cdf[x]is low) the output value ofDiscretePDF::sampleReusecan sometimes lies outside the range[0, 1]. This can be problematic for all operations down the line using the precondition (for instance