-
Notifications
You must be signed in to change notification settings - Fork 911
TLS 1.3, plaintext alert: ignore when expecting encrypted #9466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
🛟 Devin Lifeguard found 1 likely issues in this PR
@SparkiDev |
130c70d to
8943d6c
Compare
|
If the goal of this PR is to protect against DoS I don't think it's a good idea:
UDP is different but |
|
DoS can be done by any message, it doesn't have to be a valid alert. Instead the PR is about skipping alerts that were sent by the client before it received anything from the server to indicate it should be encrypted. OpenSSL and others do this. May make this a compile time option. |
|
retest this please |
julek-wolfssl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't agree with fixing it. IMO ignoring plaintext alerts is going to introduce edge cases in the transition period between plaintext and ciphertext. This in turn can hang clients/servers that think the connection is still alive when its really dead. The argument that its a DoS of a connection doesn't make any sense since injecting garbage would also kill the connection.
e2938ed to
ebc15e8
Compare
|
Changed to be compile time option when WOLFSSL_TLS13_IGNORE_PT_ALERT_ON_ENC is defined. |
ebc15e8 to
8a94314
Compare
In TLS 1.3, ignore valid unencrypted alerts that appear after encryption has started. Only ignore WOLFSSL_ALERT_COUNT_MAX-1 alerts.
8a94314 to
9bce18f
Compare
|
retest this please |
Description
In TLS 1.3, ignore valid unencrypted alerts that appear after encryption has started.
Only ignore WOLFSSL_ALERT_COUNT_MAX-1 alerts.
Fixes zd#20857
Testing
./configure --disable-shared
make
./tests/unit.test -test_tls13_plaintext_alert
Checklist