Skip to content

Fix custom error handler not restored if fatal #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Fix custom error handler not restored if fatal #1254

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
050d05d
Fix custom error handler not restored if fatal
kkmuffme Mar 27, 2025
6fd2654
Update ActionScheduler_Abstract_QueueRunner.php
kkmuffme Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions classes/abstracts/ActionScheduler_Abstract_QueueRunner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ function ( $type, $message ) {
},
E_USER_ERROR | E_RECOVERABLE_ERROR
);
add_action( 'shutdown', 'restore_error_handler', -10, 0 );

/*
* The nested try/catch structure is required because we potentially need to convert thrown errors into
Expand Down Expand Up @@ -112,6 +113,7 @@ function ( $type, $message ) {
$this->handle_action_error( $action_id, $e, $context, $valid_action );
} finally {
restore_error_handler();
remove_action( 'shutdown', 'restore_error_handler', -10 );
}

if ( isset( $action ) && is_a( $action, 'ActionScheduler_Action' ) && $action->get_schedule()->is_recurring() ) {
Expand Down