Skip to content

[Shipping labels] Remove extra divider from shipment details bottom sheet #14456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

irfano
Copy link
Contributor

@irfano irfano commented Aug 11, 2025

Part of WOOMOB-580

Description

This removes an unnecessary extra divider from the shipment details bottom sheet.

Steps to reproduce

  1. Go to orders.
  2. Select an order that has a purchased shipment.
  3. Tap Create shipping label button.
  4. Tap Shipment Details bottom to open the bottom sheet.

The tests that have been performed

Steps above

Images/gif

Before After
before-extra-line Screenshot_20250812_003438
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@irfano irfano added this to the 23.1 milestone Aug 11, 2025
@irfano irfano added feature: shipping labels Related to creating, ordering, or printing shipping labels. Bug labels Aug 11, 2025
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit92118e9
Direct Downloadwoocommerce-wear-prototype-build-pr14456-92118e9.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit92118e9
Direct Downloadwoocommerce-prototype-build-pr14456-92118e9.apk

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 37.95%. Comparing base (a8c5399) to head (92118e9).
⚠️ Report is 47 commits behind head on trunk.

Files with missing lines Patch % Lines
...oid/ui/orders/wooshippinglabels/ShipmentDetails.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #14456      +/-   ##
============================================
- Coverage     37.95%   37.95%   -0.01%     
+ Complexity     9188     9187       -1     
============================================
  Files          1989     1989              
  Lines        112311   112311              
  Branches      14814    14814              
============================================
- Hits          42630    42629       -1     
  Misses        65799    65799              
- Partials       3882     3883       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@hichamboushaba hichamboushaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @irfano

@hichamboushaba hichamboushaba merged commit 72f523e into trunk Aug 15, 2025
19 of 21 checks passed
@hichamboushaba hichamboushaba deleted the issue/WOOMOB-580-remove-extra-divider-from-shipment-details branch August 15, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug feature: shipping labels Related to creating, ordering, or printing shipping labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants