[WOOMOB-1028][Woo POS][Settings] Add Help section with product info dialog #14466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wireframes' into woomob-1028-woo-possettings-add-help-section
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
Base automatically changed from
woomob-1023-woo-possettings-2-pane-layout-based-on-the-wireframes
to
trunk
August 14, 2025 07:54
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds a Help section to the WooPos settings screen with three menu items: "Where are my products", "Documentation", and "Get support". The Help category is positioned at the bottom of the settings categories and is not part of the scrollable content, while the product info dialog now displays as a full-screen overlay instead of being confined to the details pane.
- Added Help category to settings with three options: product info, documentation, and support
- Refactored hardware settings screen to use shared component pattern
- Modified product info dialog to display full-screen instead of within the details pane
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| strings.xml | Added subtitle strings for help section menu items |
| WooPosSettingsHelpDetailViewModel.kt | New view model handling help section navigation and URL opening |
| WooPosSettingsHelpDetailScreen.kt | New composable screen displaying help menu items |
| WooPosSettingsHardwareViewModel.kt | Renamed class for consistency |
| WooPosSettingsHardwareScreen.kt | New implementation using shared menu item component |
| WooPosHardwareSettingsScreen.kt | Removed old hardware screen implementation |
| WooPosSettingsDetailsMenuItem.kt | New shared component for settings menu items |
| WooPosSettingsDetailPaneScreen.kt | Added help screen case and product dialog callback |
| WooPosSettingsCategoriesState.kt | Added HELP category enum value |
| WooPosSettingsCategoriesPaneScreen.kt | Modified layout to position Help category at bottom |
| WooPosSettingsViewModel.kt | Added dialog state management for product info dialog |
| WooPosSettingsState.kt | Added dialog state property and Help destination |
| WooPosSettingsScreen.kt | Added product info dialog overlay rendering |
| WooPosToolbarViewModel.kt | Updated import for moved documentation URL constant |
| WooPosAppUrls.kt | Added documentation URL constant |
| AppUrls.kt | Removed POS documentation URL (moved to WooPosAppUrls) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...mmerce/src/main/kotlin/com/woocommerce/android/ui/woopos/settings/WooPosSettingsViewModel.kt
Show resolved
Hide resolved
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/settings/WooPosSettingsState.kt
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #14466 +/- ##
============================================
- Coverage 37.98% 37.95% -0.03%
Complexity 9229 9229
============================================
Files 2000 2002 +2
Lines 112622 112683 +61
Branches 14855 14859 +4
============================================
- Hits 42775 42774 -1
- Misses 65951 66013 +62
Partials 3896 3896 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WOOMOB-1028
Description
Add Help section to WooPos settings screen with three menu items: "Where are my products", "Documentation", and "Get support". The Help category is positioned at the bottom of the settings categories and is not part of the scrollable content. The product info dialog now displays as a full-screen overlay instead of being confined to the details pane.
Steps to reproduce
Testing information
The tests that have been performed
Images/gif
08-13--16-13.mp4
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.