-
Notifications
You must be signed in to change notification settings - Fork 217
[SIRT] Upgrading form-data and dependents (Depends on Node upgrade) #4520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still seeing form-data 3.0.0 (and older versions) in package-lock.json.
📈 PHP Unit Code Coverage Report
|
@annemirasol The remaing form-data insecure version is a dependency of |
Fixes https://github.com/woocommerce/woocommerce-gateway-stripe/security/dependabot/128
Changes proposed in this Pull Request:
To address the critical security issue related to form-data (CWE-330), I am upgrading it directly as well as
jest
and@wordpress/scripts
, which depend on it. That's a dev-dependency (used only during building), so it is not that critical for us.Testing instructions
Code review. Check if the tests are still passing. Attempt to build the frontend files with
npm run build:webpack
. Perform some basic smoke-testing on the frontend.Changelog entry
Changelog Entry Comment
Comment
Post merge