Skip to content

Conversation

wjrosa
Copy link
Contributor

@wjrosa wjrosa commented Jul 22, 2025

Fixes https://github.com/woocommerce/woocommerce-gateway-stripe/security/dependabot/128

Changes proposed in this Pull Request:

To address the critical security issue related to form-data (CWE-330), I am upgrading it directly as well as jest and @wordpress/scripts, which depend on it. That's a dev-dependency (used only during building), so it is not that critical for us.

Testing instructions

Code review. Check if the tests are still passing. Attempt to build the frontend files with npm run build:webpack. Perform some basic smoke-testing on the frontend.


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

Post merge

@wjrosa wjrosa self-assigned this Jul 22, 2025
@wjrosa wjrosa marked this pull request as ready for review July 23, 2025 13:04
@wjrosa wjrosa changed the title Installing form-data as a dev dependency Upgrading form-data and dependents Jul 23, 2025
@wjrosa wjrosa changed the title Upgrading form-data and dependents [SIRT] Upgrading form-data and dependents Jul 23, 2025
@wjrosa wjrosa requested review from a team, annemirasol and daledupreez and removed request for a team July 23, 2025 13:14
Copy link
Contributor

@annemirasol annemirasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing form-data 3.0.0 (and older versions) in package-lock.json.

Copy link

📈 PHP Unit Code Coverage Report

Package Line Rate Health
includes/admin/class-wc-stripe-admin-notices.php 68%
includes/admin/class-wc-stripe-subscription-detached-bulk-action.php 88%
includes/class-wc-stripe-webhook-handler.php 37%
includes/class-wc-stripe.php 31%
includes/compat/class-wc-stripe-subscriptions-helper.php 88%
includes/payment-methods/class-wc-stripe-express-checkout-custom-fields.php 70%
Summary 46% (7746 / 16976)

@wjrosa
Copy link
Contributor Author

wjrosa commented Jul 24, 2025

@annemirasol The remaing form-data insecure version is a dependency of @wordpress/scripts. The version here is the latest we can support without upgrading Node. I tried to create a new version for @wordpress/scripts as well, but the wporg npmjs credentials are not working. I am afraid we will have to block this PR until we upgrade Node.

@wjrosa wjrosa added the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Jul 24, 2025
@wjrosa wjrosa changed the title [SIRT] Upgrading form-data and dependents [SIRT] Upgrading form-data and dependents (Depends on Node upgrade) Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked The issue is blocked from progressing, waiting for another piece of work to be done.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants