Node 20 upgrade lint fixes

[wjrosa]

Source PR #4264

Changes proposed in this Pull Request:

As part of the Node 20 upgrade project, this PR extracts most of the required lint fixes from the source PR (#4264). The changes here are compatible with both versions (16 and 20).

Basically, spacing of JS docblock parameters and moving function definitions before their usage.

Testing instructions

• Code review
• Check if the frontend tests and lint validations are still passing
• Checkout to this branch on your test environment (add/node-20-upgrade-lint-fixes)
• Confirm you can build the frontend files: npm run build:webpack
• Perform some basic smoke testing to confirm everything is working fine

---

• Covered with tests (or have a good reason not to test in description ☝️)
• Tested on mobile (or does not apply)

Changelog entry

• This Pull Request does not require a changelog entry. (Comment required below)

Changelog Entry Comment

Comment

Post merge

• Added testing instructions to the Release Testing Instructions wiki page (or does not apply)
• Added the needs docs label (or does not apply)
• Included this PR in the Release Thread scope (or does not apply)

[malithsen]

Nice work!

Commented on a couple of instances where we seem to exceed the intended scope of this PR but they are not necessarily merge blockers.

[malithsen]

This looks good to me.

✅ Linter runs with no errors on node 16.18.0 and 20.18.1
✅ npm run build:webpack runs on node 16 with no errors ( It fails on 20 but that's not a focus of this PR)
✅ Smoke tests

[annemirasol]

Can only test with node 16. node 20 fails setup for me.

✅ npm run lint:js
✅ npm run build:webpack
✅ Did not find any functional changes on visual code inspection. I did notice we removed some dependencies from a couple of useSelects, but it looks like they were stable fields anyways.