-
Notifications
You must be signed in to change notification settings - Fork 216
Upgrading additional packages #4638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @diegocurbelo! Would you remember why it was necessary to add the |
|
I went ahead and removed both packages. The main PR works just fine. So I think it is safe to remove them. |
It was because a couple of packages used different (and incompatible) versions of those two dependencies, and the npm resolver failed to find a version that worked for all of them; it might not be needed anymore. |
diegocurbelo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated versions work, tests pass, and Woorelease generated the package correctly (including the build folder); both flows use rimraf and cross-env.
chromedriver: for e2e tests
We are using Playwright for the E2E tests, which does not require chromedriver.
|
That's good to know, Diego! Thank you. I removed the chromedriver package in 5c9f161. And everything seems to be working just fine indeed. |
daledupreez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM, and both e2e and JS tests are looking good. ![]()
Co-authored-by: daledupreez <[email protected]>
Fixes STRIPE-696
Base PR #4264
Changes proposed in this Pull Request:
As part of the Node upgrade project, this PR upgrades additional NPM packages to match the main PR: cross-env, mkdirp, and rimraf.
We are also removing the chromedriver package, as we don't need it.
Testing instructions
dev/upgrading-additional-packages)Changelog entry
Changelog Entry Comment
Comment
Post merge