Skip to content

Conversation

@wjrosa
Copy link
Contributor

@wjrosa wjrosa commented Oct 8, 2025

See #4705 (comment)
Base PR #4613
P2 peNR48-1Jc-p2

Changes proposed in this Pull Request:

In this PR, I am just renaming the previously introduced methods in #4693 to append the _id suffix, following the new standard defined in #4705 (comment).

Testing instructions

Code review. Check if the tests are still passing. No behavior should change with this PR.


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

Post merge

@wjrosa wjrosa self-assigned this Oct 8, 2025
@wjrosa wjrosa changed the base branch from develop to dev/handling-more-stripe-order-metas October 8, 2025 14:53
@wjrosa wjrosa marked this pull request as ready for review October 8, 2025 18:02
@wjrosa wjrosa requested review from a team, daledupreez and diegocurbelo and removed request for a team October 8, 2025 18:03
@wjrosa wjrosa changed the title Renaming order helper methods to append Renaming order helper methods to append the ID suffix Oct 8, 2025
Copy link
Member

@diegocurbelo diegocurbelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. I couldn't find any calls to the old method names, and all tests pass.

Copy link
Contributor

@daledupreez daledupreez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM! Thanks for taking on this improvement.

Base automatically changed from dev/handling-more-stripe-order-metas to develop October 14, 2025 20:18
@wjrosa wjrosa enabled auto-merge (squash) October 14, 2025 20:47
@wjrosa wjrosa merged commit 032c2b0 into develop Oct 14, 2025
40 checks passed
@wjrosa wjrosa deleted the dev/renaming-order-helper-methods-to-append-id branch October 14, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants