-
Couldn't load subscription status.
- Fork 217
Renaming order helper methods to append the ID suffix #4716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming order helper methods to append the ID suffix #4716
Conversation
Co-authored-by: Mayisha <[email protected]>
Co-authored-by: Mayisha <[email protected]>
Co-authored-by: Mayisha <[email protected]>
Co-authored-by: Mayisha <[email protected]>
Co-authored-by: daledupreez <[email protected]>
…d and implementations
Co-authored-by: daledupreez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. I couldn't find any calls to the old method names, and all tests pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM! Thanks for taking on this improvement.
See #4705 (comment)
Base PR #4613
P2 peNR48-1Jc-p2
Changes proposed in this Pull Request:
In this PR, I am just renaming the previously introduced methods in #4693 to append the
_idsuffix, following the new standard defined in #4705 (comment).Testing instructions
Code review. Check if the tests are still passing. No behavior should change with this PR.
Changelog entry
Changelog Entry Comment
Comment
Post merge