Skip to content

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Nov 19, 2025

Closes WOOMOB-1733

Description

Context
Recently we added the functionality to switch to direct requests with remote sites for Jetpack sites that support application passwords.

Upon logging to the app or first switching to a store, the app would need to check if the site supports application passwords first. While that is in progress, all requests are made with Jetpack proxy by default.

Problem

There's an issue with the GET /wc-admin/onboarding/tasks API:

  • When triggered with Jetpack proxy, it would return a list of tasks including completed and incomplete ones.
  • When triggered directly with the remote site, it would just return an empty array.

On the app, we load the store onboarding card early upon logging in or switching stores. When this happens before the app could finish determining application password support in the site, the onboarding cards are loaded with Jetpack proxy.

When the user taps on view all tasks, the onboarding cards are loaded again. When this happens after the app determines that application password is supported and network switching is eligible, onboarding cards are loaded directly with the remote sites.

The inconsistent data causes a glitch: one can see 2 incomplete tasks on the dashboard screen but then sees an empty view on the full list.

Solution

To fix the above issue, I'm sending the loaded tasks from the dashboard card to the full view. I'm keeping the original logic in #9185 to fall back to loaded tasks when reloading tasks returns an empty list.

We'll need to contact someone on the backend side to look into the empty list returned from direct requests.

Test Steps

  1. Log out of the app if you haven't already.
  2. Log in to a store with incomplete tasks using WPCom credentials. For simplicity, use our shared CIAB store or a JN store with Jetpack connected.
  3. Once the dashboard completes loading, confirm that the Store setup dashboard card shows that there are 2 tasks.
  4. Tap on View all tasks and confirm that the full view shows the tasks instantly.

Screenshots

Simulator.Screen.Recording.-.iPhone.17.-.2025-11-19.at.17.46.48.mov

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added this to the 23.8 milestone Nov 19, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 19, 2025

1 Warning
⚠️ This PR is assigned to the milestone 23.7 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 19, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16369-aca3263
Version23.7
Bundle IDcom.automattic.alpha.woocommerce
Commitaca3263
Installation URL06couevcctovo
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo modified the milestones: 23.8, 23.7 ❄️ Nov 19, 2025
@itsmeichigo itsmeichigo marked this pull request as ready for review November 19, 2025 10:53
@RafaelKayumov RafaelKayumov self-assigned this Nov 20, 2025
Copy link
Contributor

@RafaelKayumov RafaelKayumov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Works as described.

@itsmeichigo itsmeichigo merged commit 0989bfb into release/23.7 Nov 21, 2025
18 checks passed
@itsmeichigo itsmeichigo deleted the woomob-1733-ios-missing-store-setup-content- branch November 21, 2025 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants