Updated wordpress-rs and request country #22037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Project dependencies changeslist! Upgraded Dependencies
rs.wordpress.api:android:trunk-8abd2196b7679acae6097b9beacbf5f1c0545c1e, (changed from trunk-d6ea38c25176ffa2fa3ce8539ae6b078d58cfdad)
rs.wordpress.api:kotlin:trunk-8abd2196b7679acae6097b9beacbf5f1c0545c1e, (changed from trunk-d6ea38c25176ffa2fa3ce8539ae6b078d58cfdad)tree +--- project :libs:fluxc
-| \--- rs.wordpress.api:android:trunk-d6ea38c25176ffa2fa3ce8539ae6b078d58cfdad
-| +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
-| +--- com.squareup.okhttp3:okhttp-tls:4.12.0
-| | +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
-| | +--- com.squareup.okio:okio:3.6.0 -> 3.9.0 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
-| +--- net.java.dev.jna:jna:5.17.0
-| +--- rs.wordpress.api:kotlin:trunk-d6ea38c25176ffa2fa3ce8539ae6b078d58cfdad
-| | +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
-| | +--- com.squareup.okhttp3:okhttp-tls:4.12.0 (*)
-| | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 (*)
-| \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 (*)
+| \--- rs.wordpress.api:android:trunk-8abd2196b7679acae6097b9beacbf5f1c0545c1e
+| +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+| +--- com.squareup.okhttp3:okhttp-tls:4.12.0
+| | +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+| | +--- com.squareup.okio:okio:3.6.0 -> 3.9.0 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
+| +--- net.java.dev.jna:jna:5.17.0
+| +--- rs.wordpress.api:kotlin:trunk-8abd2196b7679acae6097b9beacbf5f1c0545c1e
+| | +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+| | +--- com.squareup.okhttp3:okhttp-tls:4.12.0 (*)
+| | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 (*)
-\--- rs.wordpress.api:android:trunk-d6ea38c25176ffa2fa3ce8539ae6b078d58cfdad (*)
+\--- rs.wordpress.api:android:trunk-8abd2196b7679acae6097b9beacbf5f1c0545c1e (*) |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the wordpress-rs dependency to include support for requesting subscriber country information and modifies the subscribers API call to include country data. The UI already supports displaying country information when available, so no frontend changes were required.
- Updates
wordpress-rsdependency hash to include country support functionality - Adds country field to subscriber API requests to populate country data in subscriber details
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| gradle/libs.versions.toml | Updates wordpress-rs dependency hash to newer version with country support |
| WordPress/src/main/java/org/wordpress/android/ui/subscribers/SubscribersViewModel.kt | Adds country field inclusion to subscriber API requests |
|
| App Name |  WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22037-5a8735a | |
| Commit | 5a8735a | |
| Direct Download | wordpress-prototype-build-pr22037-5a8735a.apk |
|
| App Name |  Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22037-5a8735a | |
| Commit | 5a8735a | |
| Direct Download | jetpack-prototype-build-pr22037-5a8735a.apk |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #22037 +/- ##
=======================================
Coverage 39.02% 39.02%
=======================================
Files 2153 2153
Lines 101494 101494
Branches 15585 15585
=======================================
Hits 39613 39613
Misses 58384 58384
Partials 3497 3497 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
FYI: there was a conflict with this other change, and I've resolved it when merging |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
wordpress-rshash to include this change which supports adding the country when requesting subscribers. Note that the UI already supported showing the country when available, so nothing had to change there.To test