-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Move more pods to SPM #23395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move more pods to SPM #23395
Conversation
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr23395-9ffd18c | |
Version | 25.1 | |
Bundle ID | org.wordpress.alpha | |
Commit | 9ffd18c | |
App Center Build | WPiOS - One-Offs #10248 |
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr23395-9ffd18c | |
Version | 25.1 | |
Bundle ID | com.jetpack.alpha | |
Commit | 9ffd18c | |
App Center Build | jetpack-installable-builds #9296 |
dyanmic_framework_pods = %w[WordPressFlux] | ||
# Statically linking Sentry results in a conflict with `NSDictionary.objectAtKeyPath`, but dynamically | ||
# linking it resolves this. | ||
dyanmic_framework_pods += %w[Sentry SentryPrivate] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing it was affecting – likely unintentionally – is Aztec that was linked statically six targets: apps, and share and draft extensions, increasing the app size. It's not included as a dynamic framework, reducing the app size.
Note: Aztec is also linked statically in Gutenberg, but that's fine and doesn't cause any linker issues.
2c61426
to
c4d9ecb
Compare
c4d9ecb
to
0eb5f47
Compare
Generated by 🚫 Danger |
8214071
to
13c85e5
Compare
Related PRs:
To test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: