Skip to content

Conversation

kean
Copy link
Contributor

@kean kean commented Jun 28, 2024

  • Install MediaEditor, FSInteractiveMap, and Gravatar using SPK
  • Cleanup CocoaPods (details in the comments) – this is another small improvement in app size, down from 113.6 MB to 113.1 MB (-0.5 MB)

Related PRs:

To test:

  • Verify that the media editor doesn't crash and displays its custom icons

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean requested a review from jkmassel June 28, 2024 14:07
@kean kean added the Tooling Build, Release, and Validation Tools label Jun 28, 2024
@kean kean added this to the Pending milestone Jun 28, 2024
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 28, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23395-9ffd18c
Version25.1
Bundle IDorg.wordpress.alpha
Commit9ffd18c
App Center BuildWPiOS - One-Offs #10248
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 28, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23395-9ffd18c
Version25.1
Bundle IDcom.jetpack.alpha
Commit9ffd18c
App Center Buildjetpack-installable-builds #9296
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean removed the request for review from jkmassel June 28, 2024 17:13
@kean kean marked this pull request as draft June 28, 2024 17:13
@kean kean changed the title Install MediaEditor using SPM Move more pods to SPM Jun 28, 2024
dyanmic_framework_pods = %w[WordPressFlux]
# Statically linking Sentry results in a conflict with `NSDictionary.objectAtKeyPath`, but dynamically
# linking it resolves this.
dyanmic_framework_pods += %w[Sentry SentryPrivate]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing it was affecting – likely unintentionally – is Aztec that was linked statically six targets: apps, and share and draft extensions, increasing the app size. It's not included as a dynamic framework, reducing the app size.

Note: Aztec is also linked statically in Gutenberg, but that's fine and doesn't cause any linker issues.

@kean kean force-pushed the task/remove-cocoapods-p2 branch from 2c61426 to c4d9ecb Compare June 28, 2024 17:52
@kean kean force-pushed the task/remove-cocoapods-p2 branch from c4d9ecb to 0eb5f47 Compare June 28, 2024 18:23
@kean kean marked this pull request as ready for review June 28, 2024 18:37
@kean kean requested a review from jkmassel June 28, 2024 20:01
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

Base automatically changed from task/xcode-targets-wp to task/xcode-targets-merge-trunk July 5, 2024 19:25
Base automatically changed from task/xcode-targets-merge-trunk to tonyli-xcode-target-authenticator July 5, 2024 19:27
@kean kean force-pushed the tonyli-xcode-target-authenticator branch from 8214071 to 13c85e5 Compare July 5, 2024 19:48
Base automatically changed from tonyli-xcode-target-authenticator to trunk July 5, 2024 21:49
@kean kean added this pull request to the merge queue Jul 5, 2024
@kean kean removed this pull request from the merge queue due to a manual request Jul 5, 2024
@kean kean merged commit 5236003 into trunk Jul 5, 2024
@kean kean deleted the task/remove-cocoapods-p2 branch July 5, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tooling Build, Release, and Validation Tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants