-
Notifications
You must be signed in to change notification settings - Fork 1.1k
refactor: Use GutenbergKit configuration builder #24662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use GutenbergKit configuration builder #24662
Conversation
WordPress/Classes/ViewRelated/NewGutenberg/NewGutenbergViewController.swift
Outdated
Show resolved
Hide resolved
125229e to
518ebe3
Compare
|
c69fd9d to
4a258ed
Compare
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 29081 | |
| Version | PR #24662 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 90a32af | |
| Installation URL | 23nbinuv6sjb8 |
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 29081 | |
| Version | PR #24662 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 90a32af | |
| Installation URL | 1ipv6c1e0kh2g |
4a258ed to
49126f1
Compare
Adopt the latest patterns to embrace immutable configuration.
49126f1 to
cfc5d97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkmassel when testing the prototype build, I noted the theme styles were not loaded when I had the Experimental Block Editor Styles feature enabled. When I built this branch locally in Xcode 26 RC, I encountered a crash (image below) in the editor settings request logic. I imagine the crash/failed request explains the absence of theme styles (and rest of the editor settings).
Do you encounter this? What might be occurring?
WordPress/Classes/Utility/Editor/EditorConfigurationBuilder+Blog.swift
Outdated
Show resolved
Hide resolved
0817212 to
45ba29d
Compare
|
The crash is addressed in 45ba29d – it mostly shouldn't happen in production, that's the Core Data thread sanitizer complaining that we're accessing a Core Data object on the wrong thread. I reworked the initialization of that service to resolve it. The root cause is likely that I removed I'd be a little bit surprised if this was the cause of the missing theme styles, but it's possible. |
dcalhoun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The latest changes tested well for me.
I noted we no longer set the post ID and type. We should likely reinstate setting those. Other than that, we just need a PR approval from someone other than me as the PR author.
WordPress/Classes/ViewRelated/NewGutenberg/NewGutenbergViewController.swift
Show resolved
Hide resolved
dcalhoun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest changes look good to me, tested well too.
I integrated a new GBK prerelease tag. This is ready for approval and merge by someone other than me (the PR author).
WordPress/Classes/ViewRelated/NewGutenberg/NewGutenbergViewController.swift
Show resolved
Hide resolved
|






Description
Adopt the latest patterns for embracing immutable configuration introduced in wordpress-mobile/GutenbergKit#146.
Testing instructions
Smoke test editor functionality dependent upon configuration—theme styles, media uploads, remote editor (plugins), etc.