Skip to content

Conversation

@dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Jul 9, 2025

Description

Adopt the latest patterns for embracing immutable configuration introduced in wordpress-mobile/GutenbergKit#146.

Testing instructions

Smoke test editor functionality dependent upon configuration—theme styles, media uploads, remote editor (plugins), etc.

@dcalhoun dcalhoun added [Type] Task Gutenberg Editing and display of Gutenberg blocks. labels Jul 9, 2025
@dcalhoun dcalhoun force-pushed the refactor/use-gutenberg-kit-configuration-builder branch 2 times, most recently from 125229e to 518ebe3 Compare August 5, 2025 13:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 5, 2025

@jkmassel jkmassel force-pushed the refactor/use-gutenberg-kit-configuration-builder branch 2 times, most recently from c69fd9d to 4a258ed Compare September 11, 2025 18:55
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 11, 2025

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number29081
VersionPR #24662
Bundle IDorg.wordpress.alpha
Commit90a32af
Installation URL23nbinuv6sjb8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 11, 2025

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number29081
VersionPR #24662
Bundle IDcom.jetpack.alpha
Commit90a32af
Installation URL1ipv6c1e0kh2g
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@jkmassel jkmassel force-pushed the refactor/use-gutenberg-kit-configuration-builder branch from 4a258ed to 49126f1 Compare September 11, 2025 19:07
@jkmassel jkmassel force-pushed the refactor/use-gutenberg-kit-configuration-builder branch from 49126f1 to cfc5d97 Compare September 11, 2025 19:33
@jkmassel jkmassel marked this pull request as ready for review September 11, 2025 19:34
Copy link
Member Author

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkmassel when testing the prototype build, I noted the theme styles were not loaded when I had the Experimental Block Editor Styles feature enabled. When I built this branch locally in Xcode 26 RC, I encountered a crash (image below) in the editor settings request logic. I imagine the crash/failed request explains the absence of theme styles (and rest of the editor settings).

Xcode crash Image

Do you encounter this? What might be occurring?

@jkmassel jkmassel force-pushed the refactor/use-gutenberg-kit-configuration-builder branch from 0817212 to 45ba29d Compare September 17, 2025 16:30
@jkmassel
Copy link
Contributor

jkmassel commented Sep 17, 2025

The crash is addressed in 45ba29d – it mostly shouldn't happen in production, that's the Core Data thread sanitizer complaining that we're accessing a Core Data object on the wrong thread. I reworked the initialization of that service to resolve it.

The root cause is likely that I removed @MainActor from fetchSettingsFromAPI in cfc5d97. That annotation was keeping all access to self.blog on the main thread, at the cost of interrupting the main thread to dispatch the HTTP request (which isn't ideal).

I'd be a little bit surprised if this was the cause of the missing theme styles, but it's possible.

@jkmassel jkmassel assigned dcalhoun and unassigned dcalhoun Sep 17, 2025
Copy link
Member Author

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The latest changes tested well for me.

I noted we no longer set the post ID and type. We should likely reinstate setting those. Other than that, we just need a PR approval from someone other than me as the PR author.

Copy link
Member Author

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes look good to me, tested well too.

I integrated a new GBK prerelease tag. This is ready for approval and merge by someone other than me (the PR author).

@dcalhoun dcalhoun added this to the 26.4 milestone Sep 19, 2025
@sonarqubecloud
Copy link

@jkmassel jkmassel added this pull request to the merge queue Sep 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 19, 2025
@dcalhoun dcalhoun added this pull request to the merge queue Sep 19, 2025
Merged via the queue into trunk with commit 9bd75e4 Sep 19, 2025
31 of 33 checks passed
@dcalhoun dcalhoun deleted the refactor/use-gutenberg-kit-configuration-builder branch September 19, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Editing and display of Gutenberg blocks. [Type] Task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants