Skip to content

Conversation

crazytonyli
Copy link
Contributor

Note

This PR depends on #24771 and will be merged after it.

Description

The first couple of commits copy the Test code from the WordPressKit repo without any changes. There are small changes to them in later commits.

Testing instructions

@crazytonyli crazytonyli added this to the 26.2 milestone Aug 29, 2025
@crazytonyli crazytonyli requested a review from kean August 29, 2025 01:42
@dangermattic
Copy link
Collaborator

dangermattic commented Aug 29, 2025

2 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@crazytonyli crazytonyli force-pushed the wordpresskit-spm-unit-tests branch from 1ac722a to 118f2b7 Compare August 29, 2025 01:51
"name" : "WordPressSharedTests"
"containerPath" : "container:WordPress.xcodeproj",
"identifier" : "4A8280FC2E5FE9B60037E180",
"name" : "WordPressKitTests"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the new test target to the existing test plan file. I guess Xcode did not care about the order of the target which made the diff pretty difficult to review.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Aug 29, 2025

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number28699
VersionPR #24776
Bundle IDorg.wordpress.alpha
Commitcffdcaf
Installation URL0rt9hhg7raffg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Aug 29, 2025

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number28699
VersionPR #24776
Bundle IDcom.jetpack.alpha
Commitcffdcaf
Installation URL5jcv4g9itad20
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot wpmobilebot modified the milestones: 26.2, 26.3 Aug 29, 2025
@wpmobilebot
Copy link
Contributor

Version 26.2 has now entered code-freeze, so the milestone of this PR has been updated to 26.3.

Base automatically changed from wordpresskit-spm to trunk August 31, 2025 23:06
@crazytonyli crazytonyli force-pushed the wordpresskit-spm-unit-tests branch from d9192e7 to cffdcaf Compare August 31, 2025 23:43
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5 Security Hotspots

See analysis details on SonarQube Cloud

@crazytonyli crazytonyli added this pull request to the merge queue Sep 2, 2025
Merged via the queue into trunk with commit e5759b3 Sep 2, 2025
29 of 32 checks passed
@crazytonyli crazytonyli deleted the wordpresskit-spm-unit-tests branch September 2, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants