Remove deprecated message for MFA module #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Removes @deprecated attribute from WorkOS.MFA module while maintaining documentation about deprecation status, addressing build failures for projects using --warnings-as-errors flag.
- Removed
@deprecatedattribute fromlib/workos/mfa.exto fix compilation errors while keeping informational deprecation notice in documentation - Change confirmed with WorkOS support that standalone MFA features will remain active
- Helps projects using strict compiler settings (--warnings-as-errors) to build successfully
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #71
Read issue for more details.
I confirmed with WorkOS support that the standalone MFA module is not planned for removal.
The current
@deprecatedtag breaks builds for teams using--warnings-as-errors.This PR removes the
@deprecatedtag to avoid misleading warnings for projects that rely on this module.