Conditionally pass Behat --xdebug flag
#276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
schlessera
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This logic was previously in the reusable workflow in the
wp-cli/.githubrepo, but in wp-cli/.github#157 I removed it (mostly by accident).I forgot that
wp-cli/wp-cli-bundleruns tests with Behat 3.15 which doesn't know the--xdebug(which is why we had this check in the first place). It's easier to check forWP_CLI_TEST_COVERAGEin this script itself. This makes local testing easier as well, so you only need to runWP_CLI_TEST_COVERAGE=truecomposer behatand don't need to remember whether you need to pass-- --xdebug` as well or not.