fix(types): use TType for DocumentEventMap key in ctx.addEventListener #1863
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes an incorrect type definition in
ContentScriptContext.addEventListener
with Document targets.Previously, the method signature defined the parameter as:
Here, type was hardcoded as
keyof DocumentEventMap
instead of using the genericTType
.This caused type inference issues when registering event listeners, making TypeScript report incompatibility errors (e.g., with click handlers typed as
PointerEvent
).The fix updates the method signature to:
This ensures proper type inference for the event handler parameter.
Manual Testing
Create a content script using
ctx.addEventListener
with different event types:Confirm that TypeScript correctly infers the handler parameter type depending on the event name.
Related Issue
N/A.