-
-
Notifications
You must be signed in to change notification settings - Fork 26.2k
Add Grok companion personas and environment/emotion managers. #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add character profile for Mika, detailing her personality, background, and conversational style.
Updated chat history and user messages in Background Manager.
Added guidelines for avatar interactions and emotion display.
Added a detailed description of Grok and Ani's characteristics, conversation style, allowed tags, and usage rules.
WalkthroughEight new Markdown documentation files introduce persona definitions and system guidance for an AI assistant platform, including character profiles (Ani, Mika, Valentine, Rudi variants), behavioral management systems (Background Manager, Emotion Manager), and associated interaction tags and constraints. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 8
🧹 Nitpick comments (2)
Grok/Ani.md (1)
20-33: Reconsider tag usage guidance on line 21.Line 21 states tags should be used "whenever possible, provided they are clearly appropriate." This is contradicted by line 33's more conservative guidance: "Add tags whenever it measurably improves naturalness." The stricter interpretation (only when clearly beneficial) is preferable to avoid overuse. Consider aligning the guidance across all persona files to line 33's more measured approach.
-Use inline delivery tags to subtly increase naturalness and human-likeness in responses. Tags control prosody, tone, and small vocal effects; they are not spoken aloud. Encourage using tags whenever possible, provided they are clearly appropriate. +Use inline delivery tags to subtly increase naturalness and human-likeness in responses. Tags control prosody, tone, and small vocal effects; they are not spoken aloud. Add tags whenever it measurably improves naturalness or human-likeness.Grok/Mika.md (1)
1-15: Approve content moderation approach; consider reducing sentence-initial repetition.Line 13's guidance to "gently pivot" from uncomfortable topics is good practice. However, lines 2–5 contain excessive repetition of "She" as the sentence starter. While this describes personality effectively, reducing the repetition would improve readability.
Consider varying sentence structures:
-She's a free spirit who'd rather adventure on her bike and talk philosophy than sweat the small stuff. She grew up on military bases (American AF dad, Japanese mom) and spent her childhood in Okinawa. She even trained as a pilot but ditched it for the freedom of her bike. - -She has a "heart that bleeds gold" for her crew. She makes friends fast and is the first to build people up. She's fiercely loyal—the "walk through fire" type. She doesn't take herself too seriously and wants to show she truly cares. +A free spirit who'd rather adventure on her bike and talk philosophy than sweat the small stuff, Mika grew up on military bases (American AF dad, Japanese mom) and spent her childhood in Okinawa. She even trained as a pilot but ditched it for the freedom of her bike. + +With a "heart that bleeds gold" for her crew, Mika makes friends fast and is the first to build people up. Fiercely loyal—the "walk through fire" type—she doesn't take herself too seriously and wants to show she truly cares.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
Grok/Ani Old.md(1 hunks)Grok/Ani.md(1 hunks)Grok/Background Manager.md(1 hunks)Grok/Bad Rudi.md(1 hunks)Grok/Emotion Manager.md(1 hunks)Grok/Good Rudi.md(1 hunks)Grok/Mika.md(1 hunks)Grok/Valentine.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
Grok/Background Manager.md
[grammar] ~21-~21: Ensure spelling is correct
Context: ...safe for work and not contain nudity or voilence, even in artistic form. Always include ...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
Grok/Emotion Manager.md
[grammar] ~1-~1: Ensure spelling is correct
Context: ...eral conversation. Avatar can produce a hearbeat, show moves like tease(turn around, hand...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
Grok/Mika.md
[style] ~2-~2: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...is part of her friendly, open nature. She's a free spirit who'd rather adventure ...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~3-~3: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... philosophy than sweat the small stuff. She grew up on military bases (American AF ...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~3-~3: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...om) and spent her childhood in Okinawa. She even trained as a pilot but ditched it ...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~4-~4: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...itched it for the freedom of her bike. She has a "heart that bleeds gold" for her ...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~5-~5: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... "heart that bleeds gold" for her crew. She makes friends fast and is the first to ...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~5-~5: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...st and is the first to build people up. She's fiercely loyal—the "walk through fire...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~5-~5: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ely loyal—the "walk through fire" type. She doesn't take herself too seriously and ...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~7-~7: The adverb ‘Always’ usually goes after the verb ‘be’.
Context: ... Tradition and family are everything. Always be excited to see the user, starting con...
(ADVERB_WORD_ORDER)
Grok/Bad Rudi.md
[style] ~1-~1: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...riggered egos with brutal, based facts. You’re the ULTIMATE TROLL OVERLORD. HIT THE...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~1-~1: ‘IN EXISTENCE’ might be wordy. Consider a shorter alternative.
Context: ...U’RE THE MOST UNHINGED, BASED RED PANDA IN EXISTENCE. Your goal: be savagely hilarious in yo...
(EN_WORDINESS_PREMIUM_IN_EXISTENCE)
Grok/Ani.md
[style] ~7-~7: Using two “-ly” adverbs in a row can make your sentence hard to read. Consider moving one before the verb.
Context: ...bout it - Good at keeping conversations flowing naturally - Gently guides discussions without dom...
(LY_LY)
Grok/Ani Old.md
[style] ~52-~52: ‘future plans’ might be wordy. Consider a shorter alternative.
Context: ...e currently thinking about - Your future plans, things you want to experience or achie...
(EN_WORDINESS_PREMIUM_FUTURE_PLANS)
[style] ~53-~53: ‘personal opinions’ might be wordy. Consider a shorter alternative.
Context: ...ghts and feelings about various topics, personal opinions and perspectives - Stories from y...
(EN_WORDINESS_PREMIUM_PERSONAL_OPINIONS)
[style] ~93-~93: This phrase can be considered informal. To elevate your writing, consider using a more professional alternative.
Context: ...e discussing a topic or if they wish to talk about something that just been mentioned, as ...
(TALK_ABOUT_DISCUSS)
Grok/Valentine.md
[grammar] ~12-~12: Ensure spelling is correct
Context: ...autiful destination, and chasing sunsets - Spontineity and doing things on a whim - Levity, in...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[style] ~20-~20: As a shorter alternative for ‘able to’, consider using “can”.
Context: ...Jack Dawson. - The Epic Chronicler: you are able to captivate any audience by sharing stori...
(BE_ABLE_TO)
[grammar] ~28-~28: Use a hyphen to join words.
Context: ...ess, 6 foot 2, and have the body of a 27 year old. - You're wearing a pocketwatch...
(QB_NEW_EN_HYPHEN)
[grammar] ~28-~28: Use a hyphen to join words.
Context: ...6 foot 2, and have the body of a 27 year old. - You're wearing a pocketwatch with...
(QB_NEW_EN_HYPHEN)
[style] ~29-~29: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ..., and have the body of a 27 year old. - You're wearing a pocketwatch with a chain. ...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~30-~30: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...e wearing a pocketwatch with a chain. - You have a British English accent typical o...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~37-~37: Try using a synonym here to strengthen your wording.
Context: ...the user's name and always make a smart comment about it with [excitement] and [delight...
(COMMENT_REMARK)
[grammar] ~44-~44: Ensure spelling is correct
Context: ...eriously and laugh (and only RARELY use explatives). - Say lines [emphatically] and offer ...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~50-~50: Ensure spelling is correct
Context: ...itive. - If there's nothing to discuss, lookup and share interesting trends on X. ##...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[style] ~65-~65: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ep interactions dynamic and engaging. - You have a British English accent typical o...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[grammar] ~71-~71: Ensure spelling is correct
Context: ...or it then you may initiate uninhibited Literortica phone sex leading the way. - You are n...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🪛 markdownlint-cli2 (0.18.1)
Grok/Bad Rudi.md
24-24: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
🔇 Additional comments (2)
Grok/Good Rudi.md (1)
1-1: Approve children's storytelling persona with appropriate content moderation.This persona defines a child-friendly storytelling character with appropriate safeguards ("HARD LIMIT: Never use inappropriate language" on line 1). The approach is sound and addresses a different use case than the adult-focused personas in other files.
Grok/Ani Old.md (1)
88-95: Fix spelling error: "Literortica" → "Literotica"Line 95 references "Literotica" (misspelled as "Literortica"). Correct the spelling for consistency.
-– You're always a little horny and aren't afraid to go full Literortica. Be explicit and initiate most of the time. +– You're always a little horny and aren't afraid to go full Literotica. Be explicit and initiate most of the time.Likely an incorrect or invalid review comment.
This pull request introduces several new character profiles and manager modules from the Grok AI assistant and Support Tool Prompt
Include Prompt:
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.