Improve LinstorSR.py to handle thick SR creation #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wescoeur
requested changes
Apr 22, 2025
rushikeshjadhav
force-pushed
the
3.2.3-8.3-online-hosts
branch
2 times, most recently
from
697676c to
2b681af
Compare
Wescoeur
approved these changes
Apr 29, 2025
|
I changed the base branch to 3.2.12-8.3, can you rebase on it? Thanks! :) |
Nambrok
requested changes
Apr 29, 2025
…In some drivers e.g. Linstor, we need to ensure that hosts are enabeld before performing operations, hence this function is needed. Signed-off-by: Rushikesh Jadhav <[email protected]>
…as the metrics could take time. Thus, changed the mechanism to `get_enabled_hosts`. Signed-off-by: Rushikesh Jadhav <[email protected]>
rushikeshjadhav
force-pushed
the
3.2.3-8.3-online-hosts
branch
from
2b681af to
2395ddb
Compare
Nambrok
approved these changes
Apr 29, 2025
|
@rushikeshjadhav Have you tested this code in real condition already? |
Yes, it's being referred and tested in xcp-ng/xcp-ng-tests#282. It's in Draft and will convert once done. |
|
I won't have time to review this one. |
|
@stormi kindly check if its suitable to merge or hold till we enable "thick" back? Ref xcp-ng/xcp-ng-tests#305 |
|
@rushikeshjadhav I prefer to let the storage team merge PRs on this repository. CC @Nambrok |
Wescoeur
reviewed
Jun 16, 2025
Avoiding extra step and variable. Co-authored-by: Ronan Abhamon <[email protected]> Signed-off-by: Rushikesh Jadhav <[email protected]>
Nambrok
approved these changes
Jun 25, 2025
Wescoeur
changed the title
thick SR creation
Wescoeur
changed the title
Wescoeur
pushed a commit
that referenced
this pull request
Aug 28, 2025
Check enabled hosts instead of online during SR creation Added `get_enabled_hosts` to get enabled hosts during SR operations. In some drivers e.g. LINSTOR, we need to ensure that hosts are enabled before performing operations, hence this function is needed. In some cases `thick` SR creation may fail due to `get_online_hosts` as the metrics could take time. Signed-off-by: Rushikesh Jadhav <[email protected]>
Wescoeur
pushed a commit
that referenced
this pull request
Aug 28, 2025
Check enabled hosts instead of online during SR creation Added `get_enabled_hosts` to get enabled hosts during SR operations. In some drivers e.g. LINSTOR, we need to ensure that hosts are enabled before performing operations, hence this function is needed. In some cases `thick` SR creation may fail due to `get_online_hosts` as the metrics could take time. Signed-off-by: Rushikesh Jadhav <[email protected]>
Wescoeur
pushed a commit
that referenced
this pull request
Aug 28, 2025
Check enabled hosts instead of online during SR creation Added `get_enabled_hosts` to get enabled hosts during SR operations. In some drivers e.g. LINSTOR, we need to ensure that hosts are enabled before performing operations, hence this function is needed. In some cases `thick` SR creation may fail due to `get_online_hosts` as the metrics could take time. Signed-off-by: Rushikesh Jadhav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases
thickSR creation may fail due toget_online_hostsas the metrics could take time. Thus, changed the mechanism toget_enabled_hosts.