Rewrite generic storage tests to deduplicate #281
Conversation
Nambrok
force-pushed
the
dtt-generic-storage
branch
from
7a50d8a to
1157685
Compare
Signed-off-by: Damien Thenot <[email protected]>
Nambrok
force-pushed
the
dtt-generic-storage
branch
from
1157685 to
c3a5fd4
Compare
Signed-off-by: Damien Thenot <[email protected]>
| @@ -75,6 +75,13 @@ def pytest_addoption(parser): | |||
| "4KiB blocksize to be formatted and used in storage tests. " | |||
| "Set it to 'auto' to let the fixtures auto-detect available disks." | |||
| ) | |||
| parser.addoption( | |||
| "--sr-type", | |||
There was a problem hiding this comment.
This is another added parameter to control which tests should be executed or not, which adds a layer between test definitions themselves and job definitions (jobs.py). I see a lot of PRs adding parameters, and this looks like added complexity for the ones running the tests.
How do you express "all storage types except largeblock and linstor" with this? (see job definitions in jobs.py that rely on this)
There was a problem hiding this comment.
This only include ext and lvm since those were identical. I agree it's not optimal, I'm looking into a way that will involve giving a path to pytest.
There was a problem hiding this comment.
Couldn't we use test class inheritance and still keep individual test files?
There was a problem hiding this comment.
I'm gonna try new things for this PR, gonna see if we can do something better with inheritance or other mechanisms.
Remove
tests/storage/{lvm,ext}that were duplicated tests.Add
tests/storage/genericto replace them.Add a parameter
--sr-typeto select which SR types to run generic tests on.If the parameter is set to
all, it will run on all members of the list defined intests/storage/generic/conftest.py:SR_TYPES(containing lvm and ext SR types for the moment).Also adapt jobs definition with the new parameter.