packages in pipe report #680
Conversation
|
Looks like a good candidate for a sync review. |
You can't get the koji build ID and links to the web interface from repos directly. |
glehmann
force-pushed
the
pkg-in-pipe
branch
2 times, most recently
from
55ae5cb to
6f29e52
Compare
scripts/pkg_in_pipe/README.md
Outdated
|
|
||
| ```sh | ||
| docker build -f pkg_in_pipe . | ||
| docker run -v ~/.koji:/root/.koji:z -e PLANE_TOKEN=<plane token> -v /out/dir:/output:z pkg_in_pipe /output/index.html |
There was a problem hiding this comment.
We should document in README that a directory from the host should me mounted in the container, and that a positional argument is used to specify the output path and filename inside the container, shouldn't we?
glehmann
force-pushed
the
pkg-in-pipe
branch
2 times, most recently
from
336d713 to
f14946b
Compare
|
@nathanael-h I have also added the last generation time and generation interval in the report |
glehmann
force-pushed
the
pkg-in-pipe
branch
3 times, most recently
from
4b42ed2 to
10b532b
Compare
|
@glehmann let's discuss it together with @nathanael-h in the coming days? |
glehmann
force-pushed
the
pkg-in-pipe
branch
3 times, most recently
from
56bbe01 to
139539f
Compare
glehmann
force-pushed
the
pkg-in-pipe
branch
2 times, most recently
from
03a273a to
42496a3
Compare
scripts/pkg_in_pipe/pkg_in_pipe.py
Outdated
| return sorted(prs, key=lambda p: p.number, reverse=True) | ||
|
|
||
| parser = argparse.ArgumentParser(description='Generate a report of the packages in the pipe') | ||
| parser.add_argument('output', nargs='?', help='Report output path', default='report.html') | ||
| parser.add_argument('--generated-info', help="Add this message about the generation in the report") | ||
| parser.add_argument('--plane-token', help="The token used to access the plane api", default=os.environ['PLANE_TOKEN']) |
There was a problem hiding this comment.
Removed by mistake, reintroduced with different indent in next commit (reinident would belong to first commit)
There was a problem hiding this comment.
not a style fix: I used environ.get() to not raise an exception if the envar is not defined.
but indeed it was removed by mistake
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]> Co-authored-by: Nathanaël <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
|
Removing myself from the code reviewers for this one. I'll continue providing feedback on the end result, independently of the implementation. |
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.