this fixes issue116 and explicitly maintains the aspect ratio in the … #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fullscreen, independent of however the SDL_WINDOW_FULLSCREEN works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue116 and explicitly maintains the aspect ratio in the fullscreen, independent of however the SDL_WINDOW_FULLSCREEN works.
If the other pull request from me has been merged then this one can be rejected I guess.
In addition to changing the SDL flag, I added a few lines of code, that explicitly adjust the new aspect ratio, based on the original aspect ratio.
Although, in my honest opinion, this is a bit of an overkill. I think the other pull request is sufficient.
Still, I compiled and tested both solutions and then seemed to work within reason.