Skip to content

Conversation

@charlesseizilles
Copy link

No description provided.

@vercel
Copy link

vercel bot commented Dec 12, 2025

@charlesseizilles is attempting to deploy a commit to the waruqi's projects Team on Vercel.

A member of the Team first needs to authorize it.

@netlify
Copy link

netlify bot commented Dec 12, 2025

Deploy Preview for mellow-creponne-9cce3d failed.

Name Link
🔨 Latest commit 8cb1de7
🔍 Latest deploy log https://app.netlify.com/projects/mellow-creponne-9cce3d/deploys/693c13a35f1c6e000848deb9

@gemini-code-assist
Copy link

Summary of Changes

Hello @charlesseizilles, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the clarity and consistency of documentation examples. It updates specific code snippets in the API documentation to use the os.projectdir() function instead of the $(projectdir) variable. This modification ensures that users configuring module and plugin directories in their xmake.lua files are guided towards a more standardized and reliable method for path resolution.

Highlights

  • Documentation Update: Replaced the use of the $(projectdir) variable with the os.projectdir() function in code examples within the docs/api/description/global-interfaces.md file.
  • Consistency and Robustness: The change promotes a more programmatic and potentially robust way to reference the project directory in xmake.lua configuration examples for add_moduledirs and add_plugindirs.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation to use os.projectdir() instead of $(projectdir), which is a good improvement. I've suggested using path.join for better cross-platform path construction. Additionally, it seems this change has not been applied to all relevant documentation files. For instance, the Chinese version of this document (docs/zh/api/description/global-interfaces.md) and other examples in docs/api/scripts/builtin-modules/os.md still use the old $(projectdir) syntax. It would be great to update them as well for consistency.


```lua
add_moduledirs("$(projectdir)/modules")
add_moduledirs(os.projectdir() .. "/modules")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better cross-platform compatibility and code clarity when constructing paths, it's recommended to use path.join() instead of string concatenation. This ensures that the correct path separator is used regardless of the operating system.

Suggested change
add_moduledirs(os.projectdir() .. "/modules")
add_moduledirs(path.join(os.projectdir(), "modules"))


```lua
add_plugindirs("$(projectdir)/plugins")
add_plugindirs(os.projectdir() .. "/plugins")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better cross-platform compatibility and code clarity when constructing paths, it's recommended to use path.join() instead of string concatenation. This ensures that the correct path separator is used regardless of the operating system.

Suggested change
add_plugindirs(os.projectdir() .. "/plugins")
add_plugindirs(path.join(os.projectdir(), "plugins"))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant