-
-
Notifications
You must be signed in to change notification settings - Fork 482
Auto-update samurai to v0.26.1 #8305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs an automated update of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request automatically updates the samurai
package to version v0.26.1
. The change correctly adds the new version and its hash. However, there is a potential issue with a dependency that may not have been updated by the automation script. The xtensor
dependency is currently pinned to <0.26.0
, which might be incompatible with the new samurai
version and could lead to build failures.
add_urls("https://github.com/hpc-maths/samurai/archive/refs/tags/$(version).tar.gz", | ||
"https://github.com/hpc-maths/samurai.git") | ||
|
||
add_versions("v0.26.1", "07971b2c5359cc33f5e3fb3f4f7d156b6aed91441139a1ae133378ba25e46d7a") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The automation has correctly added the new version v0.26.1
. However, it seems the script does not update dependencies. The package currently depends on xtensor < 0.26.0
(line 23). It's highly likely that a new version of samurai
requires a newer version of its dependencies. If samurai v0.26.1
requires xtensor >= 0.26.0
, this package definition will be incorrect and cause build failures. Please update the dependency constraints in add_deps
to match the requirements of samurai v0.26.1
.
New version of samurai detected (package version: v0.25.1, last github version: v0.26.1)