eigen: update to 3.4.1

[choyy]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @choyy, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on updating the Eigen library to its latest version, 3.4.1, within the package management system. It also includes several build process optimizations and minor corrections to ensure a more efficient and accurate installation, particularly by disabling the building of demos and documentation and refining the Linux package source name.

Highlights

• Eigen Version Update: The eigen package has been updated to version 3.4.1, including its corresponding checksum.
• Optimized Build Configuration: The build process for Eigen now explicitly disables the compilation of demos and documentation, leading to a leaner installation.
• Linux Package Source Correction: The pacman external source for Linux platforms has been corrected from pacman::eigen to pacman::eigen3.
• Test Snippet Refinement: The C++ test snippet has been simplified by removing unnecessary iostream includes and std::cout statements, focusing solely on core matrix operations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the Eigen package to version 3.4.1. The changes also include several improvements to the package definition file, such as consolidating add_includedirs calls, adding more CMake flags to disable building tests, demos, and docs for a faster and cleaner installation, and cleaning up the test snippet. However, I've found an issue with the external source definition for pacman on Linux, which I've commented on. Overall, good improvements alongside the version bump.

[gemini-code-assist]

The pacman package for Eigen on Linux distributions like Arch Linux is named eigen, not eigen3. This change will likely break the external source installation for users on those systems. Please revert this to pacman::eigen.

        add_extsources("pacman::eigen", "apt::libeigen3-dev")