lame: enable shared build.

[Redbeanw44602]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @Redbeanw44602, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modifies the xmake.lua configuration for the lame package to enable the building of shared libraries. By removing the readonly constraint and updating the description of the shared configuration, users can now choose to compile lame as a dynamic library, offering greater flexibility for integration into various projects.

Highlights

• Shared Library Configuration: The shared configuration for the lame package has been updated to explicitly enable building shared libraries. The description now clearly states 'Build shared library.'.
• Configuration Flexibility: The readonly = true attribute has been removed from the shared configuration, allowing users to now modify this option and build lame as a shared library.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enables shared library builds for the lame package by making the shared configuration option user-configurable. The change is correct for Unix-like platforms. However, the implementation is incomplete as it does not include the necessary logic for building a shared library on Windows. I've added a comment with details on how to complete the Windows implementation.

[Redbeanw44602]

Is it possible to disable debug option on certain platforms?
package.tools.autoconf will automatically add --enable-debug😕

http://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/

[waruqi]

Is it possible to disable debug option on certain platforms? package.tools.autoconf will automatically add --enable-debug😕

http://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/

add_configs + debug/default = false + readonly

[Redbeanw44602]

🤔🤔debug doesn't seem to be a common config (like shared)?

add_deps("xxx", {debug = true, configs = {shared = true}})

[waruqi]

🤔🤔debug doesn't seem to be a common config (like shared)?

add_deps("xxx", {debug = true, configs = {shared = true}})

it's an alias, you can also use

add_deps("xxx", {configs = {shared = true, debug = true}})

[Issues-translate-bot]

Bot detected the issue body's language is not English, translate it automatically.

---

🤔🤔debug doesn't seem to be a common config (like shared)?

add_deps("xxx", {debug = true, configs = {shared = true}})

it's a alias, you can also use

add_deps("xxx", {configs = {shared = true, debug = true}})