-
-
Notifications
You must be signed in to change notification settings - Fork 486
ng-log: add package #8378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ng-log: add package #8378
Conversation
Summary of ChangesHello @HOMODELUNA, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求将 ng-log C++ 日志库引入到仓库中。此举是由于 google glog 即将归档,而 ng-log 作为其轻量级且 API 兼容的替代方案。主要更改是添加了 xmake.lua 配置文件,以实现 ng-log 的构建和集成,包括其各种依赖项和平台特定设置。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
此拉取请求添加了对 ng-log
包的支持,作为 glog
的替代品。整体实现是合理的,但在依赖管理和 API 使用方面有一些可以改进的地方。我提出了一些建议,以提高构建的稳定性和代码的健壮性。
if config == "gflags" then | ||
package:add("deps", "gflags master") | ||
else | ||
package:add("deps", dep) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should supply https://github.com/gflags/gflags/pull/367.diff as patch to gflags package instead of checking out next to master branch.
发现报错的地方都是windows + 动态库 + MT, 推测是库本身不支持MT运行时, |
google glog于2025年6月30日存档,并停止维护, 有两个可能的替代品:
abseil库 有日志功能, 它已经在仓库中
ng-log 是一个轻量级日志库, 与glog保持api兼容