Skip to content

[Feat] Add setup completion tracking to prevent multiple setup calls #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025
Merged

[Feat] Add setup completion tracking to prevent multiple setup calls #187

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2482bfc
feat: add setup completion tracking to prevent multiple setup calls
JongtaekChoi Jul 21, 2025
ba995ac
refactor: change setup completion handling to reject instead of resolve
JongtaekChoi Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ios/LineLoginModule.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import Foundation
import LineSDK

@objc(LineLogin) public class LineLogin: NSObject {

@objc public static func application(
_ application: UIApplication,
open url: URL,
Expand All @@ -20,7 +21,12 @@ import LineSDK

@objc func setup(_ arguments: NSDictionary, resolver resolve: @escaping RCTPromiseResolveBlock,
rejecter reject: @escaping RCTPromiseRejectBlock) {


if LoginManager.shared.isSetupFinished {
reject("SETUP_ALREADY_COMPLETED", "Setup has already been completed", nil)
return
}

guard let channelID = arguments["channelId"] as? String else {
reject("INVALID_ARGUMENTS", "Missing required argument: channelId", nil)
return
Expand Down