Skip to content

ref: create common ancestor for custom ops #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
Merged

ref: create common ancestor for custom ops #1338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions python/xorq/expr/relations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,11 @@ def __dask_tokenize__(self):
)


class CachedNode(ops.DatabaseTable):
class DatabaseTableView(ops.DatabaseTable):
pass


class CachedNode(DatabaseTableView):
parent: Any = None
storage: Any = None

Expand All @@ -154,7 +158,7 @@ class CachedNode(ops.DatabaseTable):
)


class RemoteTable(ops.DatabaseTable):
class RemoteTable(DatabaseTableView):
remote_expr: Expr = None

@classmethod
Expand All @@ -172,7 +176,7 @@ def into_backend(expr, con, name=None):
return RemoteTable.from_expr(con=con, expr=expr, name=name).to_expr()


class FlightExpr(ops.DatabaseTable):
class FlightExpr(DatabaseTableView):
input_expr: Expr = None
unbound_expr: Expr = None
make_server: Callable = None
Expand Down Expand Up @@ -318,7 +322,7 @@ def flight_expr(
)


class FlightUDXF(ops.DatabaseTable):
class FlightUDXF(DatabaseTableView):
input_expr: Expr = None
# FIXME: fix circular import issue so we can possibly pass an instance of AbstractExchanger
udxf: type = None
Expand Down
Loading