Skip to content

Conversation

@dlovell
Copy link
Collaborator

@dlovell dlovell commented Oct 13, 2025

No description provided.

@dlovell dlovell requested a review from hussainsultan October 13, 2025 19:19
@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
python/xorq/caching/__init__.py 93.70% <100.00%> (+0.47%) ⬆️
python/xorq/tests/test_ls_accessor.py 100.00% <100.00%> (ø)
python/xorq/vendor/ibis/expr/types/core.py 85.24% <100.00%> (+0.24%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 13, 2025

CodSpeed Performance Report

Merging #1340 will not alter performance

Comparing feat/hashing/tokenized-snapshot (e7c8bc5) with main (df01e91)

Summary

✅ 3 untouched

@dlovell dlovell marked this pull request as draft October 14, 2025 13:14
@dlovell
Copy link
Collaborator Author

dlovell commented Oct 14, 2025

per discussion with @hussainsultan , we might want to default hashing to use the "snapshot" version and only invoke the more involved modification time strategy hashing when explicitly needed by a cache key calculation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant