Skip to content

Conversation

@dlovell
Copy link
Collaborator

@dlovell dlovell commented Nov 25, 2024

No description provided.

@dlovell dlovell requested a review from mesejo November 25, 2024 13:06
@dlovell dlovell force-pushed the feat/add-file-sort-order branch from 407f1c6 to 6807622 Compare November 25, 2024 13:11
Copy link
Collaborator

@mesejo mesejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parquet_utils.py file is missing

@dlovell dlovell force-pushed the feat/add-file-sort-order branch from 6807622 to d6d0593 Compare January 10, 2025 03:59
@codecov
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 90.41096% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
python/letsql/backends/let/tests/conftest.py 73.91% 6 Missing ⚠️
python/letsql/expr/__init__.py 75.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
python/letsql/backends/let/__init__.py 78.46% <100.00%> (+1.22%) ⬆️
python/letsql/backends/let/tests/test_client.py 100.00% <100.00%> (ø)
python/letsql/common/utils/parquet_utils.py 100.00% <100.00%> (ø)
python/letsql/expr/__init__.py 85.71% <75.00%> (-14.29%) ⬇️
python/letsql/backends/let/tests/conftest.py 89.87% <73.91%> (-6.56%) ⬇️

... and 1 file with indirect coverage changes

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 10, 2025

CodSpeed Performance Report

Merging #379 will degrade performances by 55.08%

Comparing feat/add-file-sort-order (d6d0593) with main (3e4c438)

Summary

❌ 1 regressions
✅ 1 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main feat/add-file-sort-order Change
test_into_backend_cache 105.5 ms 234.8 ms -55.08%

@dlovell dlovell marked this pull request as draft August 13, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants