Skip to content

Fix build with Clang for Windows #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Clemoot
Copy link
Contributor

@Clemoot Clemoot commented Jul 18, 2025

I am trying to compile and use xsimd with Clang on Windows.

I just discovered that Clang for Windows doesn't define __GNUC__ but instead defines _MSC_VER. That makes the compiler choose a version of XSIMD_INLINE that it does not support.

The only solution I found that do supports both platforms is by extending #if defined(__GNUC__) with (defined(_MSC_VER) && defined(__clang__).

@serge-sans-paille
Copy link
Contributor

@serge-sans-paille
Copy link
Contributor

(and thanks for spotting this!)

@Clemoot Clemoot force-pushed the fix-clang-windows-build branch from c784bd2 to a2b1f99 Compare July 23, 2025 17:35
@Clemoot
Copy link
Contributor Author

Clemoot commented Jul 23, 2025

I updated the changes, which in fact are way cleaner with your suggestion.

@serge-sans-paille serge-sans-paille merged commit e2a4395 into xtensor-stack:master Jul 26, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants