XCOMMONS-3451: Realtime editing doesn't support clustering #1475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmassol
reviewed
Oct 10, 2025
| try { | ||
| user.getSession().getBasicRemote().sendText(text); | ||
| } catch (IOException e) { | ||
| throw new NetfluxException("Faield to send the message [%s] to use [%s]".formatted(text, user), e); |
vmassol
reviewed
Oct 10, 2025
| * @param user the user to send the message to | ||
| * @param text the message to be sent. | ||
| * @throws IllegalArgumentException if the text is {@code null}. | ||
| * @throws NetfluxException when failing to send the message |
Member
There was a problem hiding this comment.
small inconsistencies in ending dots (sometimes there's a dot, sometimes there isn't)
vmassol
reviewed
Oct 10, 2025
| import org.xwiki.netflux.internal.user.local.LocalUser; | ||
|
|
||
| /** | ||
| * {@link UserHandler} implementation for {@link LocalUser}. |
Member
There was a problem hiding this comment.
is this javadoc correct? It's the same as LocalUserHandler's.
vmassol
reviewed
Oct 10, 2025
| .getInstance(new DefaultParameterizedType(null, UserHandler.class, user.getClass())); | ||
| } catch (ComponentLookupException e) { | ||
| throw new NoUserHandlerException( | ||
| "Failed to find a UserHandler for type [%s]".formatted(user.getClass())); |
tmortagne
force-pushed
the
feature-realtime-cluster
branch
5 times, most recently
from
7b23e1c to
651de05
Compare
tmortagne
force-pushed
the
feature-realtime-cluster
branch
7 times, most recently
from
4c568b3 to
04a7ae7
Compare
tmortagne
force-pushed
the
feature-realtime-cluster
branch
from
04a7ae7 to
ad7f3f1
Compare
tmortagne
force-pushed
the
feature-realtime-cluster
branch
from
ad7f3f1 to
1fbe7f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
Changes
Description
xwiki-platform side of things: xwiki/xwiki-platform#4656
TODO:
Clarifications
The general idea is to distribute everything that happens (user joining, leaving, updates) on all cluster nodes.
Screenshots & Video
Executed Tests
Expected merging strategy