Skip to content

fix(typeahead): Set parse key to valid when selecting exact match #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(typeahead): Set parse key to valid when selecting exact match #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/typeahead/test/typeahead.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,6 +599,16 @@ describe('typeahead tests', function () {

expect(element).toBeOpenWithActive(2, 0);
});

it('should set \'parse\' key as valid when selecting a perfect match and not editable', function () {
var element = prepareInputEl('<div ng-form="test"><input name="typeahead" ng-model="result" typeahead="state as state.name for state in states | filter:$viewValue" typeahead-editable="false"></div>');
var inputEl = findInput(element);

changeInputValueTo(element, 'Alaska');
triggerKeyDown(element, 13);

expect($scope.test.typeahead.$error.parse).toBeUndefined();
});
});

describe('input formatting', function () {
Expand Down
1 change: 1 addition & 0 deletions src/typeahead/typeahead.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ angular.module('mm.foundation.typeahead', ['mm.foundation.position', 'mm.foundat
model = parserResult.modelMapper(originalScope, locals);
$setModelValue(originalScope, model);
modelCtrl.$setValidity('editable', true);
modelCtrl.$setValidity('parse', true);

onSelectCallback(originalScope, {
$item: item,
Expand Down