fix(sdks): improve typescript-language-server PnP auto import support #6870
      
        
          +224
        
        
          −1
        
        
          
        
      
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Summary
This PR fixes inconsistent auto import behavior when using
typescript-language-serverwith PnP environments (Fixes #6845).Problem
The issue reported that auto imports work inconsistently in PnP environments when using
typescript-language-serverwith Neovim. Some imports likePutObjectCommandwork correctly, while others likeAaaaRecordfail to auto-import despite being suggested.Root Cause
typescript-language-serverhadnullconfiguration in the VSCode SDK, unlike the regulartypescriptpackagetypescript-language-serverwasn't receiving the same TypeScript server monkey patches that handle PnP virtual path resolution and auto importsSolution
typescript-language-serverwith proper TypeScript SDK configurationtypescript-language-serverbase wrapper, including:Changes
packages/yarnpkg-sdks/sources/sdks/vscode.ts: AddedgenerateTypescriptLanguageServerWrapperand updated SDK configurationpackages/yarnpkg-sdks/sources/sdks/base.ts: Enhanced base wrapper with comprehensive TypeScript server monkey patchesTesting
yarn test:unit)yarn test:lint)yarn constraints)Package Version
The
@yarnpkg/sdkspackage has been modified and will need a version bump as detected byyarn version check.Fixes #6845