Skip to content

feat: add network section #2621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: astandrik.2447-3
Choose a base branch
from
Open

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented Jul 25, 2025

Closes #2448

Stand

CI Results

Test Status: ❌ FAILED

📊 Full Report

Total Passed Failed Flaky Skipped
354 108 244 0 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: 🔺

Current: 85.30 MB | Main: 85.22 MB
Diff: +0.08 MB (0.09%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@astandrik astandrik changed the title Astandrik.2448 2 feat: add network section Jul 25, 2025
@astandrik astandrik requested a review from Copilot July 25, 2025 10:06
@astandrik
Copy link
Collaborator Author

bugbot run

Copilot

This comment was marked as outdated.

@astandrik astandrik requested a review from Copilot July 25, 2025 12:37
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Network section to the tenant diagnostics page, implementing network monitoring capabilities. The Network section provides two tabs for viewing nodes by ping time and clock skew metrics.

  • Adds network tab to the metrics overview with dedicated components for ping and skew analysis
  • Creates reusable network metric formatting utilities for speed-based legends
  • Implements tabbed interface for viewing top nodes by ping time and clock skew

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/utils/metrics/formatMetricLegend.ts Adds formatSpeedLegend function for network speed formatting
src/store/reducers/tenant/types.ts Adds TenantNetworkTab type definition
src/store/reducers/tenant/constants.ts Adds network tab constants and IDs
src/containers/Tenant/Diagnostics/TenantOverview/i18n/en.json Updates i18n keys for network section
src/containers/Tenant/Diagnostics/TenantOverview/TenantOverview.tsx Integrates TenantNetwork component
src/containers/Tenant/Diagnostics/TenantOverview/TenantNetwork/* Implements network monitoring components and utilities
src/containers/Tenant/Diagnostics/TenantOverview/TabCard/* Removes clickable prop and simplifies styling
src/containers/Tenant/Diagnostics/TenantOverview/MetricsTabs/MetricsTabs.tsx Adds network card with proper formatting and navigation
Comments suppressed due to low confidence (1)

src/containers/Tenant/Diagnostics/TenantOverview/TenantNetwork/columns.ts:40

  • The use of 'as any' type assertion bypasses TypeScript's type checking and should be avoided. Consider properly typing the fieldsRequired parameter or using a more specific type assertion.
        })),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant