Fix tx modes #2
Merged
Fix tx modes #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuckySting
requested changes
Oct 31, 2024
ydb_dbapi/connections.py
Outdated
|
|
||
| class _IsolationSettings(NamedTuple): | ||
| ydb_mode: ydb.BaseQueryTxMode | ||
| ydb_mode: ydb.BaseQueryTxMode | None |
Collaborator
There was a problem hiding this comment.
nitpick: It is always not None
| self, query: str, seq_of_parameters: Sequence[ParametersType] | ||
| ) -> None: | ||
| for parameters in seq_of_parameters: | ||
| self.execute(query, parameters) |
Collaborator
There was a problem hiding this comment.
question (non-blocking): Could we optimize this using preparation of query or just concat queries together?
Collaborator
There was a problem hiding this comment.
suggestion: commit and rollback could raise exception in case of TLI or BrokenSession. I think we should wrap them to interface exceptions
LuckySting
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.