async ca/task runner: get rid of channel/etc id lists in events #21546
Conversation
|
🟢 |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Sinks and Sources are definitely unique, sort Inputs/Outputs before check
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the task runner architecture to eliminate redundant channel/ID lists from events by initializing them once in the task runner actors instead of passing them around in events.
- Removes channel/sink ID lists from event structures (
TEvContinueRun,TEvStatistics,TWatermarkRequest,TCheckpointRequest) - Changes data structures from
THashSet<ui32>toTVector<ui32>for input/output tracking - Initializes channel/sink lists during task runner setup instead of passing them in events
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| task_runner_actor.cpp | Converts Inputs/Sources from THashSet to TVector, removes inputChannelsWithDisabledCheckpoints parameter |
| worker_actor.cpp | Changes inputChannels from THashSet to TVector in worker implementation |
| task_runner_actor_local.cpp | Major refactor to initialize all channel/sink lists locally and remove event-based ID passing |
| task_runner_actor.h | Removes inputChannelsWithDisabledCheckpoints parameter from factory interface |
| events.h | Removes ID list fields from event structures (TWatermarkRequest, TCheckpointRequest, TEvContinueRun, TEvStatistics) |
| dq_async_compute_actor.cpp | Removes ID collection logic and simplifies event creation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
...
Changelog category
Description for reviewers
Those lists are static, there are no point in passing them around in events, initialize them once.