Skip to content

Conversation

Evgenik2
Copy link
Collaborator

Changelog entry

If current and target config differs only in one node - use reassign node api
If current config has correct parameters and has no bad nodes - do not start self heal
replicas position in rings and rings order independent comparision of configs

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@Evgenik2 Evgenik2 requested a review from a team as a code owner July 23, 2025 15:16
@Evgenik2 Evgenik2 requested review from pixcc and alexvru and removed request for pixcc July 23, 2025 15:16
@Evgenik2 Evgenik2 self-assigned this Jul 23, 2025
@Evgenik2 Evgenik2 linked an issue Jul 23, 2025 that may be closed by this pull request
Copy link

🟢 2025-07-23 15:19:57 UTC The validation of the Pull Request description is successful.

@Evgenik2 Evgenik2 force-pushed the Use-reassign-node-api-in-self-heal branch from ff729c9 to c5c4c84 Compare July 23, 2025 15:35
Copy link

github-actions bot commented Jul 23, 2025

2025-07-23 15:38:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for b3ee807 has started.
2025-07-23 15:38:36 UTC Artifacts will be uploaded here
2025-07-23 15:42:01 UTC ya make is running...
🟡 2025-07-23 17:28:43 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30143 28704 0 3 1404 32

2025-07-23 17:31:29 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-07-23 17:44:55 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
298 (only retried tests) 222 0 0 50 26

🟢 2025-07-23 17:45:03 UTC Build successful.
🟢 2025-07-23 17:45:23 UTC ydbd size 2.2 GiB changed* by +34.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 674119e merge: b3ee807 diff diff %
ydbd size 2 398 968 104 Bytes 2 399 003 192 Bytes +34.3 KiB +0.001%
ydbd stripped size 501 625 928 Bytes 501 631 176 Bytes +5.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 23, 2025

2025-07-23 15:39:27 UTC Pre-commit check linux-x86_64-release-asan for b3ee807 has started.
2025-07-23 15:39:40 UTC Artifacts will be uploaded here
2025-07-23 15:42:59 UTC ya make is running...
🟡 2025-07-23 18:04:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14718 14282 0 124 292 20

🟢 2025-07-23 18:05:51 UTC Build successful.
🟢 2025-07-23 18:06:20 UTC ydbd size 3.9 GiB changed* by +42.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2dffb99 merge: b3ee807 diff diff %
ydbd size 4 218 019 520 Bytes 4 218 063 320 Bytes +42.8 KiB +0.001%
ydbd stripped size 1 461 720 024 Bytes 1 461 735 704 Bytes +15.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Evgenik2 Evgenik2 merged commit 1de9c68 into main Jul 24, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use reassign node api in self-heal
2 participants