YQ-4314 supported script executions retries #21592
Conversation
|
🟢 |
|
⚪ |
|
⚪
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Pull Request Overview
This PR implements script execution retries as part of streaming queries support. The key change is adding retry capability to script executions that fail with specific status codes, allowing them to be automatically restarted after a configured backoff period.
- Adds retry mapping functionality to script execution operations with configurable backoff policies
- Implements background lease checking to automatically restart failed script executions
- Enhances script execution metadata to track retry state and lease generation
Reviewed Changes
Copilot reviewed 55 out of 56 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| ydb/tests/tools/kqprun/src/ydb_setup.h | Defines TScriptRequest structure with retry mapping support |
| ydb/tests/tools/kqprun/src/ydb_setup.cpp | Updates ScriptRequest method to accept TScriptRequest instead of TRequestOptions |
| ydb/tests/tools/kqprun/src/kqp_runner.cpp | Implements retry policy configuration and script execution retry logic |
| ydb/core/kqp/proxy_service/kqp_script_execution_retries.h | Defines retry policy and limiter classes for script executions |
| ydb/core/kqp/proxy_service/kqp_script_execution_retries.cpp | Implements retry logic with rate limiting and backoff calculations |
| ydb/core/kqp/finalize_script_service/kqp_finalize_script_service.cpp | Adds background lease checking functionality |
| ydb/core/kqp/finalize_script_service/kqp_check_script_lease_actor.cpp | Implements periodic lease expiration checks |
| ydb/core/protos/kqp.proto | Adds retry state and policy protobuf definitions |
ydb/core/kqp/finalize_script_service/kqp_finalize_script_actor.cpp
Outdated
Show resolved
Hide resolved
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
….cpp Co-authored-by: Copilot <[email protected]>
GrigoriyPA
force-pushed
the
YQ-4314-support-script-executions-retries
branch
from
74f3b10 to
115922f
Compare
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
Supported script executions retries (part of streaming queries support)
Changelog category
Description for reviewers